Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2193353004: Add new baselines for mac-retina after swapping the machine. (Closed)

Created:
4 years, 4 months ago by qyearsley
Modified:
4 years, 4 months ago
Reviewers:
Dirk Pranke, pdr.
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add new baselines for mac-retina after swapping the machine. Background: In order to have a mac retina layout test try bot with a matching continuous bot, the slave for "WebKit Mac10.11 (retina)", which was a MacBookPro11,3 with Nvidia GPU, was swapped for a MacBookPro11,5 with AMD GPU (http://crrev.com/2184313002). After the builder came back online with the new slave, svg/text/combining-character-queries.html was failing consistently. See results: https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Mac10_11__retina_/5141/layout-test-results/results.html Committed: https://crrev.com/77aba94595e0cab5b370933cd5ef6865b55128d6 Cr-Commit-Position: refs/heads/master@{#408828}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
A third_party/WebKit/LayoutTests/platform/mac-retina/svg/text/combining-character-queries-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-retina/svg/text/combining-character-queries-expected.txt View 2 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
qyearsley
4 years, 4 months ago (2016-07-29 22:21:23 UTC) #2
pdr.
On 2016/07/29 at 22:21:23, qyearsley wrote: > LGTM, this sort of difference is expected for ...
4 years, 4 months ago (2016-07-29 23:10:57 UTC) #7
pdr.
On 2016/07/29 at 23:10:57, pdr. wrote: > On 2016/07/29 at 22:21:23, qyearsley wrote: > > ...
4 years, 4 months ago (2016-07-29 23:16:25 UTC) #8
Dirk Pranke
lgtm
4 years, 4 months ago (2016-07-29 23:42:57 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2193353004/1
4 years, 4 months ago (2016-07-30 01:06:01 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-30 01:10:30 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-07-30 01:13:40 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/77aba94595e0cab5b370933cd5ef6865b55128d6
Cr-Commit-Position: refs/heads/master@{#408828}

Powered by Google App Engine
This is Rietveld 408576698