Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 2193353002: MD Settings: invert the "Use Window Decorations" checkbox (Closed)

Created:
4 years, 4 months ago by Dan Beam
Modified:
4 years, 4 months ago
Reviewers:
dschuyler
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: invert the "Use Window Decorations" checkbox I checked that it worked, but not that it matched what the label says. My bad. R=dschuyler@chromium.org BUG=632679 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/c24c5678cb1b467120c16db24219b7e6e5374eb7 Cr-Commit-Position: refs/heads/master@{#408811}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/settings/appearance_page/appearance_page.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
Dan Beam
whoops: https://cs.chromium.org/chromium/src/chrome/browser/resources/options/browser_options.html?q=custom_chrome_frame&sq=package:chromium&l=99&dr=C
4 years, 4 months ago (2016-07-29 19:23:53 UTC) #2
dschuyler
lgtm
4 years, 4 months ago (2016-07-29 23:17:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2193353002/1
4 years, 4 months ago (2016-07-29 23:58:19 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-30 00:04:01 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-07-30 00:09:02 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c24c5678cb1b467120c16db24219b7e6e5374eb7
Cr-Commit-Position: refs/heads/master@{#408811}

Powered by Google App Engine
This is Rietveld 408576698