Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2380)

Unified Diff: runtime/bin/vmservice/client/deployed/web/index_devtools.html

Issue 219333011: Change how we provide value previews in the vm service. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: fix tests / gen js Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/vmservice/client/deployed/web/index_devtools.html
diff --git a/runtime/bin/vmservice/client/deployed/web/index_devtools.html b/runtime/bin/vmservice/client/deployed/web/index_devtools.html
index fba3ce9092a3cded62c70c7f3b961381426f5fad..4fcd5e1e29547fd05e5733688fa46374bf1880b9 100644
--- a/runtime/bin/vmservice/client/deployed/web/index_devtools.html
+++ b/runtime/bin/vmservice/client/deployed/web/index_devtools.html
@@ -298,14 +298,14 @@
</template>
<template if="{{ isNull(ref.serviceType) }}">
- <div title="{{ hoverText }}">{{ ref['preview'] }}</div>
+ <div title="{{ hoverText }}">{{ ref['valueAsString'] }}</div>
</template>
<template if="{{ (isString(ref.serviceType) ||
isBool(ref.serviceType) ||
isInt(ref.serviceType)) ||
isDouble(ref.serviceType)) }}">
- <a href="{{ url }}">{{ ref['preview'] }}</a>
+ <a href="{{ url }}">{{ ref['valueAsString'] }}</a>
</template>
<template if="{{ (isType(ref.serviceType)) }}">
@@ -1375,10 +1375,10 @@
</class-ref>
</div>
</div>
- <template if="{{ instance['preview'] != null }}">
+ <template if="{{ instance['valueAsString'] != null }}">
<div class="memberItem">
- <div class="memberName">preview</div>
- <div class="memberValue">{{ instance['preview'] }}</div>
+ <div class="memberName">value</div>
+ <div class="memberValue">{{ instance['valueAsString'] }}</div>
</div>
</template>
<div class="memberItem">

Powered by Google App Engine
This is Rietveld 408576698