Change how we provide value previews in the vm service.

runtime/vm/object.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_OBJECT_H_
 #define VM_OBJECT_H_
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "platform/utils.h"
@@ skipping 4024 matching lines @@
   // class implementing a 'call' method, return true and set the function
   // (if not NULL) to call and the context (if not NULL) to pass to the
   // function.
   bool IsCallable(Function* function, Context* context) const;
 
   // Evaluate the given expression as if it appeared in an instance
   // method of this instance and return the resulting value, or an
   // error object if evaluating the expression fails.
   RawObject* Evaluate(const String& expr) const;
 
-  // Returns a string representation of this instance in a form
-  // that is suitable for an end user.
-  //
-  // max_len is advisory, and the returned string may exceed this max
-  // length.
-  virtual const char* ToUserCString(intptr_t max_len = 40,
-                                    intptr_t nesting = 0) const;
-
   static intptr_t InstanceSize() {
     return RoundedAllocationSize(sizeof(RawInstance));
   }
 
   static RawInstance* New(const Class& cls, Heap::Space space = Heap::kNew);
 
  protected:
   virtual void PrintSharedInstanceJSON(JSONObject* jsobj, bool ref) const;
 
  private:
@@ skipping 1069 matching lines @@
   }
 
   bool IsExternal() const {
     return RawObject::IsExternalStringClassId(raw()->GetClassId());
   }
 
   void* GetPeer() const;
 
   void ToUTF8(uint8_t* utf8_array, intptr_t array_len) const;
 
+  // Produces a quoted, escaped, (possibly) truncated string.
+  const char* ToUserCString(intptr_t max_len) const;
+
   // Copies the string characters into the provided external array
   // and morphs the string object into an external string object.
   // The remaining unused part of the original string object is marked as
   // an Array object or a regular Object so that it can be traversed during
   // garbage collection.
   RawString* MakeExternal(void* array,
                           intptr_t length,
                           void* peer,
                           Dart_PeerFinalizer cback) const;
 
-  // Produces a quoted, escaped, (possibly) truncated string.
-  const char* ToUserCString(intptr_t max_len = 40,
-                            intptr_t nesting = 0) const;
-
   // Creates a new String object from a C string that is assumed to contain
   // UTF-8 encoded characters and '\0' is considered a termination character.
   // TODO(7123) - Rename this to FromCString(....).
   static RawString* New(const char* cstr, Heap::Space space = Heap::kNew);
 
   // Creates a new String object from an array of UTF-8 encoded characters.
   static RawString* FromUTF8(const uint8_t* utf8_array,
                              intptr_t array_len,
                              Heap::Space space = Heap::kNew);
 
@@ skipping 726 matching lines @@
     StorePointer(&raw_ptr()->type_arguments_, value.raw());
   }
 
   virtual bool Equals(const Instance& other) const;
 
   virtual RawInstance* CheckAndCanonicalize(const char** error_str) const {
     UNREACHABLE();
     return Instance::null();
   }
 
-  // Produces a readable representation of this array, e.g. '[1,2,3]',
-  // subject to length limits.
-  const char* ToUserCString(intptr_t max_len = 40,
-                            intptr_t nesting = 0) const;
-
   static intptr_t type_arguments_offset() {
     return OFFSET_OF(RawGrowableObjectArray, type_arguments_);
   }
 
   static intptr_t length_offset() {
     return OFFSET_OF(RawGrowableObjectArray, length_);
   }
   static intptr_t data_offset() {
     return OFFSET_OF(RawGrowableObjectArray, data_);
   }
@@ skipping 880 matching lines @@
 
 
 RawObject* MegamorphicCache::GetTargetFunction(const Array& array,
                                                intptr_t index) {
   return array.At((index * kEntryLength) + kTargetFunctionIndex);
 }
 
 }  // namespace dart
 
 #endif  // VM_OBJECT_H_