Issue 219333002: Added method getCaptivePortalStatus to networkingPrivate extension.

Issue 219333002: Added method getCaptivePortalStatus to networkingPrivate extension. (Closed)

Created:
6 years, 8 months ago by ygorshenin1

Modified:
6 years, 8 months ago

Reviewers:
mkearney1, Yoyo Zhou

CC:
chromium-reviews, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Added method getCaptivePortalStatus to networkingPrivate extension. BUG=354946 TEST=ExtensionNetworkingPrivateApiTest.* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261619

Patch Set 1 #

Patch Set 2 : Fixed tests. #

Total comments: 2

Patch Set 3 : Fix, rebase. #

Patch Set 4 : Rebase. #

Total comments: 2

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+135 lines, -2 lines)			Patch
M	chrome/browser/chromeos/net/network_portal_detector.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/extensions/api/networking_private/networking_private_api.h	View		1 chunk	+17 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/api/networking_private/networking_private_api_chromeos.cc	View		3 chunks	+31 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/api/networking_private/networking_private_api_nonchromeos.cc	View		1 chunk	+14 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/api/networking_private/networking_private_apitest.cc	View	1 2	3 chunks	+28 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/api/networking_private.json	View		2 chunks	+27 lines, -0 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/networking/test.js	View	1	1 chunk	+16 lines, -0 lines	0 comments	Download
M	extensions/browser/extension_function_histogram_value.h	View	1 2 3	1 chunk	+1 line, -0 lines	2 comments	Download

Messages

Total messages: 16 (0 generated)

Expand Messages | Collapse Messages

ygorshenin1

Yoyo for chrome/browser/* Margaret for chrome/common/*

6 years, 8 months ago (2014-03-31 13:07:05 UTC) #1

Yoyo Zhou

LGTM https://chromiumcodereview.appspot.com/219333002/diff/20001/chrome/browser/extensions/api/networking_private/networking_private_apitest.cc File chrome/browser/extensions/api/networking_private/networking_private_apitest.cc (right): https://chromiumcodereview.appspot.com/219333002/diff/20001/chrome/browser/extensions/api/networking_private/networking_private_apitest.cc#newcode460 chrome/browser/extensions/api/networking_private/networking_private_apitest.cc:460: // NetworkPortalDetector is only enabled for Chrome OS. ...

6 years, 8 months ago (2014-03-31 20:38:45 UTC) #2

ygorshenin1

https://codereview.chromium.org/219333002/diff/20001/chrome/browser/extensions/api/networking_private/networking_private_apitest.cc File chrome/browser/extensions/api/networking_private/networking_private_apitest.cc (right): https://codereview.chromium.org/219333002/diff/20001/chrome/browser/extensions/api/networking_private/networking_private_apitest.cc#newcode460 chrome/browser/extensions/api/networking_private/networking_private_apitest.cc:460: // NetworkPortalDetector is only enabled for Chrome OS. On ...

6 years, 8 months ago (2014-04-01 07:07:55 UTC) #3

mkearney1

On 2014/04/03 10:10:22, ygorshenin1 wrote: > Margaret, do you have any comments? Hi, ygor. I ...

6 years, 8 months ago (2014-04-03 21:32:50 UTC) #5

ygorshenin1

Could you please clarify what do you mean? This CL just adds an additional functionality ...

6 years, 8 months ago (2014-04-03 22:02:07 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ygorshenin@chromium.org/219333002/60001

6 years, 8 months ago (2014-04-03 22:12:58 UTC) #8

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

6 years, 8 months ago (2014-04-03 22:58:20 UTC) #9

commit-bot: I haz the power

Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel

6 years, 8 months ago (2014-04-03 22:58:22 UTC) #10

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ygorshenin@chromium.org/219333002/60001

6 years, 8 months ago (2014-04-03 23:02:07 UTC) #12

Lei Zhang

https://codereview.chromium.org/219333002/diff/60001/extensions/browser/extension_function_histogram_value.h File extensions/browser/extension_function_histogram_value.h (right): https://codereview.chromium.org/219333002/diff/60001/extensions/browser/extension_function_histogram_value.h#newcode771 extensions/browser/extension_function_histogram_value.h:771: NETWORKINGPRIVATE_GETCAPTIVEPORTALSTATUS, The next line says to update histograms.xml. Since ...

6 years, 8 months ago (2014-04-04 23:12:20 UTC) #15

ygorshenin1

6 years, 8 months ago (2014-04-07 09:20:05 UTC) #16

Message was sent while issue was closed.

https://codereview.chromium.org/219333002/diff/60001/extensions/browser/exten...
File extensions/browser/extension_function_histogram_value.h (right):

https://codereview.chromium.org/219333002/diff/60001/extensions/browser/exten...
extensions/browser/extension_function_histogram_value.h:771:
NETWORKINGPRIVATE_GETCAPTIVEPORTALSTATUS,
On 2014/04/04 23:12:20, Lei Zhang wrote:
> The next line says to update histograms.xml. Since you forgot to, I'll do it
for
> you since I'm likely the one who will add the next entry.

Thank you, Lei!

Expand Messages | Collapse Messages