Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2193323002:
Tracing: fix error checking from deflate() when compressing trace (Closed)
|
Created:
4 years, 4 months ago by caseq Modified:
4 years, 4 months ago CC:
chromium-reviews, wfh+watch_chromium.org, jam, darin-cc_chromium.org, tracing+reviews_chromium.org, glider+watch_chromium.org, bruening+watch_chromium.org, Ken Russell (switch to Gerrit) Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionTracing: fix error checking from deflate() when compressing trace
Initially broken by https://codereview.chromium.org/2150783002
BUG=629530, 630030
Committed: https://crrev.com/e0fd517bbea7b3dca905473b98391b6e0000056a
Cr-Commit-Position: refs/heads/master@{#408806}
Patch Set 1 #
Total comments: 1
Patch Set 2 : Re-enable AboutTracingIntegrationTest #Patch Set 3 : fixed typo in log message #Patch Set 4 : disabled AboutTracingIntegrationTest on Win #
Messages
Total messages: 38 (20 generated)
caseq@chromium.org changed reviewers: + primiano@chromium.org, shatch@chromium.org
Mea culpa :-(
Not really familiar with this code. LGTM in case simon doesn't get to this in time to get tracing fixed in canary. Thanks for looking at this promptly.
The CQ bit was checked by caseq@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
pfeldman@chromium.org changed reviewers: + pfeldman@chromium.org
lgtm
On 2016/07/29 18:33:49, pfeldman wrote: > lgtm Maybe also reenable AboutTracingIntegrationTest ? Feel free to do it in subsequent CL.
On 2016/07/29 18:36:51, nednguyen wrote: > On 2016/07/29 18:33:49, pfeldman wrote: > > lgtm > > Maybe also reenable AboutTracingIntegrationTest ? Feel free to do it in > subsequent CL. Good idea, done in this one.
nednguyen@google.com changed reviewers: + nednguyen@google.com
lgtm
The CQ bit was checked by caseq@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from primiano@chromium.org, pfeldman@chromium.org Link to the patchset: https://codereview.chromium.org/2193323002/#ps20001 (title: "Re-enable AboutTracingIntegrationTest")
simonhatch@chromium.org changed reviewers: + simonhatch@chromium.org
lgtm https://codereview.chromium.org/2193323002/diff/1/content/browser/tracing/tra... File content/browser/tracing/tracing_controller_impl_data_sinks.cc (right): https://codereview.chromium.org/2193323002/diff/1/content/browser/tracing/tra... content/browser/tracing/tracing_controller_impl_data_sinks.cc:256: LOG(ERROR) << "Deflate sream error: " << err; nit: sream
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by caseq@chromium.org
The CQ bit was checked by caseq@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from primiano@chromium.org, nednguyen@google.com, simonhatch@chromium.org, pfeldman@chromium.org Link to the patchset: https://codereview.chromium.org/2193323002/#ps40001 (title: "fixed typo in log message")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/07/29 18:51:09, commit-bot: I haz the power wrote: > CQ is trying da patch. Follow status at > > https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or... Looks like the test is still failing on windows with a different error this time: TimeoutException: Timed out while waiting 60s for IsJavaScriptExpressionTrue. Console output: (log) chrome://tracing/tracing.js:2581: Unrecognized metadata name: IsTimeTicksHighResolution (log) chrome://tracing/tracing.js:2581: At 39886677689117, no slice named ScheduledTasks was open. Feel free to disable it on windows & file a different bug.
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by caseq@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from primiano@chromium.org, nednguyen@google.com, simonhatch@chromium.org, pfeldman@chromium.org Link to the patchset: https://codereview.chromium.org/2193323002/#ps60001 (title: "disabled AboutTracingIntegrationTest on Win")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by caseq@chromium.org
Patchset #4 (id:60001) has been deleted
Patchset #4 (id:80001) has been deleted
The CQ bit was checked by caseq@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from primiano@chromium.org, nednguyen@google.com, simonhatch@chromium.org, pfeldman@chromium.org Link to the patchset: https://codereview.chromium.org/2193323002/#ps100001 (title: "disabled AboutTracingIntegrationTest on Win")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #4 (id:100001)
Message was sent while issue was closed.
Description was changed from ========== Tracing: fix error checking from deflate() when compressing trace Initially broken by https://codereview.chromium.org/2150783002 BUG=629530,630030 ========== to ========== Tracing: fix error checking from deflate() when compressing trace Initially broken by https://codereview.chromium.org/2150783002 BUG=629530,630030 Committed: https://crrev.com/e0fd517bbea7b3dca905473b98391b6e0000056a Cr-Commit-Position: refs/heads/master@{#408806} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/e0fd517bbea7b3dca905473b98391b6e0000056a Cr-Commit-Position: refs/heads/master@{#408806} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
