Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 2193303002: Add ES 3.0 fallback for instanced rendering (Closed)

Created:
4 years, 4 months ago by csmartdalton
Modified:
4 years, 4 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add ES 3.0 fallback for instanced rendering Adds the ability for GLInstancedRendering to use glDrawElementsInstanced when glDrawElementsIndirect is not supported. The only remaining 3.1 dependency now is EXT_texture_buffer. Also moves the cap for glDraw*Instanced out of GrCaps and into GrGLCaps. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2193303002 Committed: https://skia.googlesource.com/skia/+/4c18b62a004599d5a36ab7d772302dff2be91a3b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -49 lines) Patch
M include/gpu/GrCaps.h View 2 chunks +0 lines, -5 lines 0 comments Download
M src/gpu/GrCaps.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLCaps.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 4 chunks +10 lines, -5 lines 0 comments Download
M src/gpu/instanced/GLInstancedRendering.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/gpu/instanced/GLInstancedRendering.cpp View 6 chunks +59 lines, -34 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
csmartdalton
This obviously isn't going to have test coverage on the bots (at least in ES) ...
4 years, 4 months ago (2016-07-29 17:43:26 UTC) #3
bsalomon
lgtm
4 years, 4 months ago (2016-07-29 17:59:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2193303002/1
4 years, 4 months ago (2016-07-29 18:08:59 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 19:19:32 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/4c18b62a004599d5a36ab7d772302dff2be91a3b

Powered by Google App Engine
This is Rietveld 408576698