Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3315)

Unified Diff: cc/surfaces/surface_display_output_surface.cc

Issue 2193293004: cc: Make LayerTreeTests use a DelegatingRenderer and Display. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: display-layertreetest: windows-pixeltests-default-renderer-settings Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/surfaces/surface_display_output_surface.cc
diff --git a/cc/surfaces/surface_display_output_surface.cc b/cc/surfaces/surface_display_output_surface.cc
index 3b1d59d8aff2ab4bade8e55dac27f516d269ecaf..294840be307e20f0315fc07ccd150fc10013e419 100644
--- a/cc/surfaces/surface_display_output_surface.cc
+++ b/cc/surfaces/surface_display_output_surface.cc
@@ -75,7 +75,7 @@ void SurfaceDisplayOutputSurface::SwapBuffers(CompositorFrame frame) {
factory_.SubmitCompositorFrame(
delegated_surface_id_, std::move(frame),
- base::Bind(&SurfaceDisplayOutputSurface::SwapBuffersComplete,
+ base::Bind(&SurfaceDisplayOutputSurface::DidDrawCallback,
base::Unretained(this)));
}
@@ -153,7 +153,19 @@ void SurfaceDisplayOutputSurface::DisplaySetMemoryPolicy(
SetMemoryPolicy(policy);
}
-void SurfaceDisplayOutputSurface::SwapBuffersComplete() {
+void SurfaceDisplayOutputSurface::DisplayWillDrawAndSwap(
+ bool will_draw_and_swap,
+ const RenderPassList& render_passes) {
+ // This notification is not relevant to our client outside of tests.
+}
+
+void SurfaceDisplayOutputSurface::DisplayDidDrawAndSwap() {
+ // This notification is not relevant to our client outside of tests. We
+ // unblock the client from DidDrawCallback() when the surface is going to
+ // be drawn.
+}
+
+void SurfaceDisplayOutputSurface::DidDrawCallback() {
// TODO(danakj): Why the lost check?
if (!output_surface_lost_)
client_->DidSwapBuffersComplete();

Powered by Google App Engine
This is Rietveld 408576698