Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Issue 2193293002: Fail cleanly if we cannot open a file to write a snapshot. (Closed)

Created:
4 years, 4 months ago by rmacnak
Modified:
4 years, 4 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fail cleanly if we cannot open a file to write a snapshot. R=regis@google.com Committed: https://github.com/dart-lang/sdk/commit/acf93a6b19fdc7444a98e15f4ae32684f2df9ff7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M runtime/bin/main.cc View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
4 years, 4 months ago (2016-07-29 17:09:05 UTC) #2
regis
LGTM
4 years, 4 months ago (2016-07-29 20:49:46 UTC) #3
rmacnak
4 years, 4 months ago (2016-07-29 20:52:14 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
acf93a6b19fdc7444a98e15f4ae32684f2df9ff7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698