Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 2193203002: GN: ccache+clang needs -Qunused-arguments (Closed)

Created:
4 years, 4 months ago by mtklein_C
Modified:
4 years, 4 months ago
Reviewers:
jcgregorio
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

GN: ccache+clang needs -Qunused-arguments An alternative is to define CCACHE_CPP2, but I thought I'd try this more visible way first. (CCACHE_CPP2 may turn out to be required anyway if we start seeing warnings about tautological compares.) BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2193203002 TBR=jcgregorio@google.com NOTRY=true Committed: https://skia.googlesource.com/skia/+/830c913625ac62b16b09cc0f1dbd8f177ec493d9

Patch Set 1 #

Patch Set 2 : Whoops, there it is. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M infra/bots/recipe_modules/skia/gn_flavor.py View 1 1 chunk +9 lines, -2 lines 0 comments Download
M infra/bots/recipes/swarm_compile.expected/Build-Ubuntu-Clang-x86_64-Debug-GN.json View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2193203002/20001
4 years, 4 months ago (2016-07-29 13:02:58 UTC) #7
mtklein_C
4 years, 4 months ago (2016-07-29 13:03:00 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/830c913625ac62b16b09cc0f1dbd8f177ec493d9
4 years, 4 months ago (2016-07-29 13:03:55 UTC) #11
jcgregorio
4 years, 4 months ago (2016-07-29 13:57:54 UTC) #12
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698