third_party/WebKit/Source/modules/payments/PaymentRequest.h - Issue 2193183002: Print proper debug message in case of change event timeout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/payments/PaymentRequest.h

Issue 2193183002: Print proper debug message in case of change event timeout. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/payments/PaymentRequest.cpp » ('j') | third_party/WebKit/Source/modules/payments/PaymentRequest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/payments/PaymentRequest.h

diff --git a/third_party/WebKit/Source/modules/payments/PaymentRequest.h b/third_party/WebKit/Source/modules/payments/PaymentRequest.h

index 12b7dd5988a886ac450a702d44c3e06c53510090..77abced243fb364d27d0f1211fbdaeaf4f684e7e 100644

--- a/third_party/WebKit/Source/modules/payments/PaymentRequest.h

+++ b/third_party/WebKit/Source/modules/payments/PaymentRequest.h

@@ -69,6 +69,7 @@ public:

// PaymentUpdater:

void onUpdatePaymentDetails(const ScriptValue& detailsScriptValue) override;

void onUpdatePaymentDetailsFailure(const ScriptValue& error) override;

please use gerrit instead 2016/07/29 15:40:50 Let's change this ScriptValue to String

pals 2016/08/01 11:18:23 Done.

+ void abortPaymentRequest(const String& message) override;

please use gerrit instead 2016/07/29 15:40:50 Let's remove this method

pals 2016/08/01 11:18:23 Done.

DECLARE_TRACE();