Print proper debug message in case of change event timeout.

third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEvent.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/payments/PaymentRequestUpdateEvent.h"
 
 #include "bindings/core/v8/ExceptionState.h"
 #include "bindings/core/v8/ScriptFunction.h"
 #include "core/dom/DOMException.h"
 #include "core/dom/ExceptionCode.h"
@@ skipping 53 matching lines @@
 private:
     UpdatePaymentDetailsErrorFunction(ScriptState* scriptState, PaymentUpdater* updater)
         : ScriptFunction(scriptState)
         , m_updater(updater)
     {
         DCHECK(m_updater);
     }
 
     ScriptValue call(ScriptValue value) override
     {
         m_updater->onUpdatePaymentDetailsFailure(value);

[please use gerrit instead, 2016/07/29 15:40:50]

String message;
value.toString(message);
m_updater->onUpdatePaymentDetailsFailure(message);

[pals, 2016/08/01 11:18:23]

It was crashing if we do exactly like above. Doing the same thing in a different
way. PTAL.

[please use gerrit instead, 2016/08/01 16:57:45]

Acknowledged.

         return ScriptValue();
     }
 
     Member<PaymentUpdater> m_updater;
 };
 
 } // namespace
 
 PaymentRequestUpdateEvent::~PaymentRequestUpdateEvent()
 {
@@ skipping 37 matching lines @@
 
     promise.then(UpdatePaymentDetailsFunction::createFunction(scriptState, m_updater),
         UpdatePaymentDetailsErrorFunction::createFunction(scriptState, m_updater));
 }
 
 void PaymentRequestUpdateEvent::onTimerFired(Timer<PaymentRequestUpdateEvent>*)
 {
     if (!m_updater)
         return;
 
-    m_updater->onUpdatePaymentDetailsFailure(ScriptValue());
+    m_updater->abortPaymentRequest("Timed out as the page didn't resolve the promise from change event");

[please use gerrit instead, 2016/07/29 15:40:50]

Call onUpdatePaymentDetailsFailure("Timed out...")

[pals, 2016/08/01 11:18:23]

Done.

 }
 
 DEFINE_TRACE(PaymentRequestUpdateEvent)
 {
     visitor->trace(m_updater);
     Event::trace(visitor);
 }
 
 PaymentRequestUpdateEvent::PaymentRequestUpdateEvent()
     : m_waitForUpdate(false)
     , m_abortTimer(this, &PaymentRequestUpdateEvent::onTimerFired)
 {
 }
 
 PaymentRequestUpdateEvent::PaymentRequestUpdateEvent(const AtomicString& type, const PaymentRequestUpdateEventInit& init)
     : Event(type, init)
     , m_waitForUpdate(false)
     , m_abortTimer(this, &PaymentRequestUpdateEvent::onTimerFired)
 {
 }
 
 } // namespace blink