Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2193163002: [stubs] Classify and categorize remaining Hydrogen stubs (Closed)

Created:
4 years, 4 months ago by danno
Modified:
4 years, 4 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Classify and categorize remaining Hydrogen stubs BUG=chromium:608675 Committed: https://crrev.com/24451aa2d5500e37edcc81a19bee172538a8925a Cr-Commit-Position: refs/heads/master@{#38179}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -135 lines) Patch
M src/code-stubs.h View 1 1 chunk +152 lines, -135 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
danno
ptal
4 years, 4 months ago (2016-07-29 09:11:17 UTC) #2
Benedikt Meurer
lgtm
4 years, 4 months ago (2016-07-29 09:19:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2193163002/1
4 years, 4 months ago (2016-07-29 09:19:03 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/builds/1304) v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED, ...
4 years, 4 months ago (2016-07-29 09:20:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2193163002/20001
4 years, 4 months ago (2016-07-29 13:49:32 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-29 13:52:31 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 13:53:54 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/24451aa2d5500e37edcc81a19bee172538a8925a
Cr-Commit-Position: refs/heads/master@{#38179}

Powered by Google App Engine
This is Rietveld 408576698