Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2193143002: Revert of Reland [inspector] add inspector protocol parser test build target. (Closed)

Created:
4 years, 4 months ago by Michael Achenbach
Modified:
4 years, 4 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Reland [inspector] add inspector protocol parser test build target. (patchset #2 id:20001 of https://codereview.chromium.org/2190833004/ ) Reason for revert: Remaining win x64 errors: https://codereview.chromium.org/2187753004/ Original issue's description: > Reland [inspector] add inspector protocol parser test build target. > > BUG=chromium:580337 > > Committed: https://crrev.com/b8229434c9fd3bfef81fb77d88779d0e78d06662 > Cr-Commit-Position: refs/heads/master@{#38135} TBR=yangguo@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:580337 Committed: https://crrev.com/224e2656e8fca82c9b84a3bfa3466aa3fdaa2940 Cr-Commit-Position: refs/heads/master@{#38156}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1282 lines) Patch
M .gitignore View 2 chunks +1 line, -6 lines 0 comments Download
M DEPS View 1 chunk +2 lines, -6 lines 0 comments Download
M gypfiles/all.gyp View 1 chunk +1 line, -2 lines 0 comments Download
M gypfiles/standalone.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
D src/inspector/BUILD.gn View 1 chunk +0 lines, -102 lines 0 comments Download
D src/inspector/inspector.gyp View 1 chunk +0 lines, -100 lines 0 comments Download
D src/inspector/js_protocol.json View 1 chunk +0 lines, -990 lines 0 comments Download
M test/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D test/inspector_protocol_parser_test/BUILD.gn View 1 chunk +0 lines, -23 lines 0 comments Download
D test/inspector_protocol_parser_test/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D test/inspector_protocol_parser_test/RunTests.cpp View 1 chunk +0 lines, -17 lines 0 comments Download
D test/inspector_protocol_parser_test/inspector_protocol_parser_test.gyp View 1 chunk +0 lines, -29 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Michael Achenbach
Created Revert of Reland [inspector] add inspector protocol parser test build target.
4 years, 4 months ago (2016-07-29 07:01:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2193143002/1
4 years, 4 months ago (2016-07-29 07:01:50 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-29 07:02:03 UTC) #5
Michael Achenbach
FYI: There is also a win x64 archive bot. Maybe you can try that one ...
4 years, 4 months ago (2016-07-29 07:03:04 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 07:05:23 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/224e2656e8fca82c9b84a3bfa3466aa3fdaa2940
Cr-Commit-Position: refs/heads/master@{#38156}

Powered by Google App Engine
This is Rietveld 408576698