Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 2193133003: Add eclipse classpath for blimp. (Closed)

Created:
4 years, 4 months ago by xingliu
Modified:
4 years, 4 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add eclipse classpath for blimp. So after run gclient runhooks, we don't need to manually add java build path in eclipse. Committed: https://crrev.com/e61bd7b8d628632ed1b34548e64340f6620f2783 Cr-Commit-Position: refs/heads/master@{#408876}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M tools/android/eclipse/.classpath View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
xingliu
Hi, this CL add two src directory in Blimp in eclipse .class file.
4 years, 4 months ago (2016-07-30 00:09:40 UTC) #2
xingliu
Found michael is on OOO, add one reviewer.
4 years, 4 months ago (2016-07-30 00:21:00 UTC) #4
Xianzhu
lgtm. Nit: Remove BUG= from the description.
4 years, 4 months ago (2016-07-30 00:22:40 UTC) #5
xingliu
On 2016/07/30 00:22:40, Xianzhu wrote: > lgtm. > > Nit: Remove BUG= from the description. ...
4 years, 4 months ago (2016-07-30 03:00:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2193133003/1
4 years, 4 months ago (2016-07-30 21:12:50 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-30 21:15:35 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-07-30 21:17:29 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e61bd7b8d628632ed1b34548e64340f6620f2783
Cr-Commit-Position: refs/heads/master@{#408876}

Powered by Google App Engine
This is Rietveld 408576698