|
|
DescriptionAdd eclipse classpath for blimp.
So after run gclient runhooks, we don't need to manually add java build path in eclipse.
Committed: https://crrev.com/e61bd7b8d628632ed1b34548e64340f6620f2783
Cr-Commit-Position: refs/heads/master@{#408876}
Patch Set 1 #
Messages
Total messages: 17 (10 generated)
xingliu@chromium.org changed reviewers: + dtrainor@google.com, michaelbai@chromium.org, nyquist@chromium.org
Hi, this CL add two src directory in Blimp in eclipse .class file.
xingliu@chromium.org changed reviewers: + wangxianzhu@chromium.org
Found michael is on OOO, add one reviewer.
lgtm. Nit: Remove BUG= from the description.
Description was changed from ========== Add eclipse classpath for blimp. So after run gclient runhooks, we don't need to manually add java build path in eclipse. BUG= ========== to ========== Add eclipse classpath for blimp. So after run gclient runhooks, we don't need to manually add java build path in eclipse. ==========
On 2016/07/30 00:22:40, Xianzhu wrote: > lgtm. > > Nit: Remove BUG= from the description. Thanks.
The CQ bit was checked by xingliu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by xingliu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Add eclipse classpath for blimp. So after run gclient runhooks, we don't need to manually add java build path in eclipse. ========== to ========== Add eclipse classpath for blimp. So after run gclient runhooks, we don't need to manually add java build path in eclipse. ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Add eclipse classpath for blimp. So after run gclient runhooks, we don't need to manually add java build path in eclipse. ========== to ========== Add eclipse classpath for blimp. So after run gclient runhooks, we don't need to manually add java build path in eclipse. Committed: https://crrev.com/e61bd7b8d628632ed1b34548e64340f6620f2783 Cr-Commit-Position: refs/heads/master@{#408876} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/e61bd7b8d628632ed1b34548e64340f6620f2783 Cr-Commit-Position: refs/heads/master@{#408876} |