Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1033)

Issue 2193133002: MD History: Remove focus highlight from sidebar, add back ripples (Closed)

Created:
4 years, 4 months ago by tsergeant
Modified:
4 years, 4 months ago
Reviewers:
calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD History: Remove focus highlight from sidebar, add back ripples Per feedback from UI, this removes the grey focus highlight from the sidebar menu items. When the user explicitly uses tab to navigate the menu, the default focus outline will still appear. Also adds back in <paper-ripple>s on the menu items. BUG=608968 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/53f4e592b19399e8cb1d3792b5b7a441650b1b16 Cr-Commit-Position: refs/heads/master@{#409123}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -38 lines) Patch
M chrome/browser/resources/md_history/app.html View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/resources/md_history/app.js View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/resources/md_history/side_bar.html View 3 chunks +4 lines, -20 lines 1 comment Download
M chrome/browser/resources/md_history/side_bar.js View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
tsergeant
A quick friday arvo review for ya https://codereview.chromium.org/2193133002/diff/1/chrome/browser/resources/md_history/side_bar.html File chrome/browser/resources/md_history/side_bar.html (left): https://codereview.chromium.org/2193133002/diff/1/chrome/browser/resources/md_history/side_bar.html#oldcode70 chrome/browser/resources/md_history/side_bar.html:70: iron-selector { ...
4 years, 4 months ago (2016-07-29 06:00:10 UTC) #3
tsergeant
On 2016/07/29 06:00:10, tsergeant wrote: > A quick friday arvo review for ya > > ...
4 years, 4 months ago (2016-08-01 23:47:08 UTC) #4
calamity
lgtm
4 years, 4 months ago (2016-08-02 01:41:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2193133002/1
4 years, 4 months ago (2016-08-02 01:48:47 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-02 02:38:19 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 02:39:50 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/53f4e592b19399e8cb1d3792b5b7a441650b1b16
Cr-Commit-Position: refs/heads/master@{#409123}

Powered by Google App Engine
This is Rietveld 408576698