Set correct token position range for statement block containing moveNext call of

Set correct token position range for statement block containing moveNext call of
for-in loops (second attempt at fixing #26941).

R=hausner@google.com

Committed: https://github.com/dart-lang/sdk/commit/f3ad2b77cc2a76341c3aabcbf37e5d779b3d5d18

[regis, 2016-07-29 01:26:10]

regis@google.com changed reviewers:
+ hausner@google.com

[regis, 2016-07-29 01:26:10]

This makes sure that the block token range contains the call to moveNext and it
also starts the block at a different token position than the following loop
block. Both blocks allocate contexts and they had a matching token position
range, which could be an issue.

[hausner, 2016-07-29 17:59:35]

LGTM

https://codereview.chromium.org/2193113002/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/2193113002/diff/1/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:9032: OpenBlock();  // Implicit block around while loop.
Maybe add a comment that explains why we open a block that textually starts in
the middle of the for-in expression. I think you can copy the explanation in the
CL:

Ensure that the block token range contains the call to moveNext and it
also starts the block at a different token position than the following loop
block. Both blocks can allocate contexts and if they have a matching token
position
range, it can be an issue (cf. bug 26941)

[regis, 2016-07-29 20:29:13]

Description was changed from

==========
Set correct token position range for statement block containing moveNext call of
for-in loops (second attempt at fixing #26941).
==========

to

==========
Set correct token position range for statement block containing moveNext call of
for-in loops (second attempt at fixing #26941).

R=hausner@google.com

Committed:
https://github.com/dart-lang/sdk/commit/f3ad2b77cc2a76341c3aabcbf37e5d779b3d5d18
==========

[regis, 2016-07-29 20:29:14]

Committed patchset #2 (id:20001) manually as
f3ad2b77cc2a76341c3aabcbf37e5d779b3d5d18 (presubmit successful).

[regis, 2016-07-29 21:31:48]

Thanks

https://codereview.chromium.org/2193113002/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/2193113002/diff/1/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:9032: OpenBlock();  // Implicit block around while loop.
On 2016/07/29 17:59:35, hausner wrote:
> Maybe add a comment that explains why we open a block that textually starts in
> the middle of the for-in expression. I think you can copy the explanation in
the
> CL:
> 
> Ensure that the block token range contains the call to moveNext and it
> also starts the block at a different token position than the following loop
> block. Both blocks can allocate contexts and if they have a matching token
> position
> range, it can be an issue (cf. bug 26941)

Done.