Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2193093002: [UserScript cleanup] Remove use of ScopedVector from UserScriptSet. (Closed)

Created:
4 years, 4 months ago by lazyboy
Modified:
4 years, 4 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[UserScript cleanup] Remove use of ScopedVector from UserScriptSet. Change it to vector of unique_ptrs. Also remove an used param from UserScriptSet::OnUserScriptUpdated(). BUG=622464 Test=None, internal cleanup. Committed: https://crrev.com/8c0f270b6265c8a21fc98c42b04a627b507a0bb6 Cr-Commit-Position: refs/heads/master@{#408657}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -35 lines) Patch
M extensions/renderer/dispatcher.h View 1 chunk +1 line, -2 lines 0 comments Download
M extensions/renderer/dispatcher.cc View 1 chunk +1 line, -2 lines 0 comments Download
M extensions/renderer/script_injection_manager.h View 1 chunk +1 line, -2 lines 0 comments Download
M extensions/renderer/script_injection_manager.cc View 1 chunk +1 line, -2 lines 0 comments Download
M extensions/renderer/user_script_injector.h View 1 chunk +3 lines, -2 lines 0 comments Download
M extensions/renderer/user_script_injector.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M extensions/renderer/user_script_set.h View 3 chunks +5 lines, -3 lines 0 comments Download
M extensions/renderer/user_script_set.cc View 4 chunks +9 lines, -10 lines 0 comments Download
M extensions/renderer/user_script_set_manager.h View 1 chunk +1 line, -2 lines 0 comments Download
M extensions/renderer/user_script_set_manager.cc View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
lazyboy
I'm going to try to break up patches as I keep working on reducing UserScript ...
4 years, 4 months ago (2016-07-29 00:56:21 UTC) #4
Devlin
lgtm. nit: looks like you have a missing word in your cl description - "change ...
4 years, 4 months ago (2016-07-29 15:03:27 UTC) #7
lazyboy
Updated CL description, thanks!
4 years, 4 months ago (2016-07-29 16:27:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2193093002/1
4 years, 4 months ago (2016-07-29 16:28:19 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-29 16:34:36 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 16:37:38 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8c0f270b6265c8a21fc98c42b04a627b507a0bb6
Cr-Commit-Position: refs/heads/master@{#408657}

Powered by Google App Engine
This is Rietveld 408576698