Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: net/quic/quic_received_packet_manager_test.cc

Issue 2193073003: Move shared files in net/quic/ into net/quic/core/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: io_thread_unittest.cc Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_received_packet_manager.cc ('k') | net/quic/quic_sent_entropy_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_received_packet_manager_test.cc
diff --git a/net/quic/quic_received_packet_manager_test.cc b/net/quic/quic_received_packet_manager_test.cc
deleted file mode 100644
index ee654b75d73a1164c96895972516eca0ecf9182e..0000000000000000000000000000000000000000
--- a/net/quic/quic_received_packet_manager_test.cc
+++ /dev/null
@@ -1,396 +0,0 @@
-// Copyright 2013 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "net/quic/quic_received_packet_manager.h"
-
-#include <algorithm>
-#include <vector>
-
-#include "net/quic/quic_connection_stats.h"
-#include "net/quic/quic_flags.h"
-#include "net/quic/test_tools/quic_received_packet_manager_peer.h"
-#include "testing/gmock/include/gmock/gmock.h"
-#include "testing/gtest/include/gtest/gtest.h"
-
-using std::pair;
-using std::vector;
-
-namespace net {
-namespace test {
-
-class EntropyTrackerPeer {
- public:
- static QuicPacketNumber first_gap(
- const QuicReceivedPacketManager::EntropyTracker& tracker) {
- return tracker.first_gap_;
- }
- static QuicPacketNumber largest_observed(
- const QuicReceivedPacketManager::EntropyTracker& tracker) {
- return tracker.largest_observed_;
- }
- static int packets_entropy_size(
- const QuicReceivedPacketManager::EntropyTracker& tracker) {
- return tracker.packets_entropy_.size();
- }
- static bool IsTrackingPacket(
- const QuicReceivedPacketManager::EntropyTracker& tracker,
- QuicPacketNumber packet_number) {
- return packet_number >= tracker.first_gap_ &&
- packet_number <
- (tracker.first_gap_ + tracker.packets_entropy_.size()) &&
- tracker.packets_entropy_[packet_number - tracker.first_gap_].second;
- }
-};
-
-namespace {
-
-// Entropy of individual packets is not tracked if there are no gaps.
-TEST(EntropyTrackerTest, NoGaps) {
- QuicReceivedPacketManager::EntropyTracker tracker;
-
- tracker.RecordPacketEntropyHash(1, 23);
- tracker.RecordPacketEntropyHash(2, 42);
-
- EXPECT_EQ(23 ^ 42, tracker.EntropyHash(2));
- EXPECT_EQ(3u, EntropyTrackerPeer::first_gap(tracker));
-
- EXPECT_EQ(2u, EntropyTrackerPeer::largest_observed(tracker));
- EXPECT_EQ(0, EntropyTrackerPeer::packets_entropy_size(tracker));
- EXPECT_FALSE(EntropyTrackerPeer::IsTrackingPacket(tracker, 1));
- EXPECT_FALSE(EntropyTrackerPeer::IsTrackingPacket(tracker, 2));
-}
-
-// Entropy of individual packets is tracked as long as there are gaps.
-// Filling the first gap results in entropy getting garbage collected.
-TEST(EntropyTrackerTest, FillGaps) {
- QuicReceivedPacketManager::EntropyTracker tracker;
-
- tracker.RecordPacketEntropyHash(2, 5);
- tracker.RecordPacketEntropyHash(5, 17);
- tracker.RecordPacketEntropyHash(6, 23);
- tracker.RecordPacketEntropyHash(9, 42);
-
- EXPECT_EQ(1u, EntropyTrackerPeer::first_gap(tracker));
- EXPECT_EQ(9u, EntropyTrackerPeer::largest_observed(tracker));
- EXPECT_EQ(9, EntropyTrackerPeer::packets_entropy_size(tracker));
-
- EXPECT_EQ(5, tracker.EntropyHash(2));
- EXPECT_EQ(5 ^ 17, tracker.EntropyHash(5));
- EXPECT_EQ(5 ^ 17 ^ 23, tracker.EntropyHash(6));
- EXPECT_EQ(5 ^ 17 ^ 23 ^ 42, tracker.EntropyHash(9));
-
- EXPECT_FALSE(EntropyTrackerPeer::IsTrackingPacket(tracker, 1));
- EXPECT_TRUE(EntropyTrackerPeer::IsTrackingPacket(tracker, 2));
- EXPECT_TRUE(EntropyTrackerPeer::IsTrackingPacket(tracker, 5));
- EXPECT_TRUE(EntropyTrackerPeer::IsTrackingPacket(tracker, 6));
- EXPECT_TRUE(EntropyTrackerPeer::IsTrackingPacket(tracker, 9));
-
- // Fill the gap at 1.
- tracker.RecordPacketEntropyHash(1, 2);
-
- EXPECT_EQ(3u, EntropyTrackerPeer::first_gap(tracker));
- EXPECT_EQ(9u, EntropyTrackerPeer::largest_observed(tracker));
- EXPECT_EQ(7, EntropyTrackerPeer::packets_entropy_size(tracker));
-
- EXPECT_EQ(2 ^ 5 ^ 17, tracker.EntropyHash(5));
- EXPECT_EQ(2 ^ 5 ^ 17 ^ 23, tracker.EntropyHash(6));
- EXPECT_EQ(2 ^ 5 ^ 17 ^ 23 ^ 42, tracker.EntropyHash(9));
-
- EXPECT_FALSE(EntropyTrackerPeer::IsTrackingPacket(tracker, 1));
- EXPECT_FALSE(EntropyTrackerPeer::IsTrackingPacket(tracker, 2));
- EXPECT_TRUE(EntropyTrackerPeer::IsTrackingPacket(tracker, 5));
- EXPECT_TRUE(EntropyTrackerPeer::IsTrackingPacket(tracker, 6));
- EXPECT_TRUE(EntropyTrackerPeer::IsTrackingPacket(tracker, 9));
-
- // Fill the gap at 4.
- tracker.RecordPacketEntropyHash(4, 2);
-
- EXPECT_EQ(3u, EntropyTrackerPeer::first_gap(tracker));
- EXPECT_EQ(9u, EntropyTrackerPeer::largest_observed(tracker));
- EXPECT_EQ(7, EntropyTrackerPeer::packets_entropy_size(tracker));
-
- EXPECT_EQ(5, tracker.EntropyHash(4));
- EXPECT_EQ(5 ^ 17, tracker.EntropyHash(5));
- EXPECT_EQ(5 ^ 17 ^ 23, tracker.EntropyHash(6));
- EXPECT_EQ(5 ^ 17 ^ 23 ^ 42, tracker.EntropyHash(9));
-
- EXPECT_FALSE(EntropyTrackerPeer::IsTrackingPacket(tracker, 3));
- EXPECT_TRUE(EntropyTrackerPeer::IsTrackingPacket(tracker, 4));
- EXPECT_TRUE(EntropyTrackerPeer::IsTrackingPacket(tracker, 5));
- EXPECT_TRUE(EntropyTrackerPeer::IsTrackingPacket(tracker, 6));
- EXPECT_TRUE(EntropyTrackerPeer::IsTrackingPacket(tracker, 9));
-
- // Fill the gap at 3. Entropy for packets 3 to 6 are forgotten.
- tracker.RecordPacketEntropyHash(3, 2);
-
- EXPECT_EQ(7u, EntropyTrackerPeer::first_gap(tracker));
- EXPECT_EQ(9u, EntropyTrackerPeer::largest_observed(tracker));
- EXPECT_EQ(3, EntropyTrackerPeer::packets_entropy_size(tracker));
-
- EXPECT_EQ(2 ^ 5 ^ 17 ^ 23 ^ 42, tracker.EntropyHash(9));
-
- EXPECT_FALSE(EntropyTrackerPeer::IsTrackingPacket(tracker, 3));
- EXPECT_FALSE(EntropyTrackerPeer::IsTrackingPacket(tracker, 4));
- EXPECT_FALSE(EntropyTrackerPeer::IsTrackingPacket(tracker, 5));
- EXPECT_FALSE(EntropyTrackerPeer::IsTrackingPacket(tracker, 6));
- EXPECT_TRUE(EntropyTrackerPeer::IsTrackingPacket(tracker, 9));
-
- // Fill in the rest.
- tracker.RecordPacketEntropyHash(7, 2);
- tracker.RecordPacketEntropyHash(8, 2);
-
- EXPECT_EQ(10u, EntropyTrackerPeer::first_gap(tracker));
- EXPECT_EQ(9u, EntropyTrackerPeer::largest_observed(tracker));
- EXPECT_EQ(0, EntropyTrackerPeer::packets_entropy_size(tracker));
-
- EXPECT_EQ(2 ^ 5 ^ 17 ^ 23 ^ 42, tracker.EntropyHash(9));
-}
-
-TEST(EntropyTrackerTest, SetCumulativeEntropyUpTo) {
- QuicReceivedPacketManager::EntropyTracker tracker;
-
- tracker.RecordPacketEntropyHash(2, 5);
- tracker.RecordPacketEntropyHash(5, 17);
- tracker.RecordPacketEntropyHash(6, 23);
- tracker.RecordPacketEntropyHash(9, 42);
-
- EXPECT_EQ(1u, EntropyTrackerPeer::first_gap(tracker));
- EXPECT_EQ(9u, EntropyTrackerPeer::largest_observed(tracker));
- EXPECT_EQ(9, EntropyTrackerPeer::packets_entropy_size(tracker));
-
- // Inform the tracker about value of the hash at a gap.
- tracker.SetCumulativeEntropyUpTo(3, 7);
- EXPECT_EQ(3u, EntropyTrackerPeer::first_gap(tracker));
- EXPECT_EQ(9u, EntropyTrackerPeer::largest_observed(tracker));
- EXPECT_EQ(7, EntropyTrackerPeer::packets_entropy_size(tracker));
-
- EXPECT_EQ(7 ^ 17, tracker.EntropyHash(5));
- EXPECT_EQ(7 ^ 17 ^ 23, tracker.EntropyHash(6));
- EXPECT_EQ(7 ^ 17 ^ 23 ^ 42, tracker.EntropyHash(9));
-
- // Inform the tracker about value of the hash at a known location.
- tracker.SetCumulativeEntropyUpTo(6, 1);
- EXPECT_EQ(7u, EntropyTrackerPeer::first_gap(tracker));
- EXPECT_EQ(9u, EntropyTrackerPeer::largest_observed(tracker));
- EXPECT_EQ(3, EntropyTrackerPeer::packets_entropy_size(tracker));
-
- EXPECT_EQ(1 ^ 23 ^ 42, tracker.EntropyHash(9));
-
- // Inform the tracker about value of the hash at the last location.
- tracker.SetCumulativeEntropyUpTo(9, 21);
- EXPECT_EQ(10u, EntropyTrackerPeer::first_gap(tracker));
- EXPECT_EQ(9u, EntropyTrackerPeer::largest_observed(tracker));
- EXPECT_EQ(0, EntropyTrackerPeer::packets_entropy_size(tracker));
-
- EXPECT_EQ(42 ^ 21, tracker.EntropyHash(9));
-}
-
-struct TestParams {
- explicit TestParams(QuicVersion version) : version(version) {}
-
- friend std::ostream& operator<<(std::ostream& os, const TestParams& p) {
- os << "{ version: " << QuicVersionToString(p.version) << " }";
- return os;
- }
-
- QuicVersion version;
-};
-
-vector<TestParams> GetTestParams() {
- vector<TestParams> params;
- QuicVersionVector all_supported_versions = QuicSupportedVersions();
- for (size_t i = 0; i < all_supported_versions.size(); ++i) {
- params.push_back(TestParams(all_supported_versions[i]));
- }
- return params;
-}
-
-class QuicReceivedPacketManagerTest
- : public ::testing::TestWithParam<TestParams> {
- protected:
- QuicReceivedPacketManagerTest() : received_manager_(&stats_) {
- received_manager_.SetVersion(GetParam().version);
- }
-
- void RecordPacketReceipt(QuicPacketNumber packet_number,
- QuicPacketEntropyHash entropy_hash) {
- RecordPacketReceipt(packet_number, entropy_hash, QuicTime::Zero());
- }
-
- void RecordPacketReceipt(QuicPacketNumber packet_number,
- QuicPacketEntropyHash entropy_hash,
- QuicTime receipt_time) {
- QuicPacketHeader header;
- header.packet_number = packet_number;
- header.entropy_hash = entropy_hash;
- received_manager_.RecordPacketReceived(0u, header, receipt_time);
- }
-
- QuicConnectionStats stats_;
- QuicReceivedPacketManager received_manager_;
-};
-
-INSTANTIATE_TEST_CASE_P(QuicReceivedPacketManagerTest,
- QuicReceivedPacketManagerTest,
- ::testing::ValuesIn(GetTestParams()));
-
-TEST_P(QuicReceivedPacketManagerTest, ReceivedPacketEntropyHash) {
- if (GetParam().version > QUIC_VERSION_33) {
- return;
- }
- vector<pair<QuicPacketNumber, QuicPacketEntropyHash>> entropies;
- entropies.push_back(std::make_pair(1, 12));
- entropies.push_back(std::make_pair(7, 1));
- entropies.push_back(std::make_pair(2, 33));
- entropies.push_back(std::make_pair(5, 3));
- entropies.push_back(std::make_pair(8, 34));
-
- for (size_t i = 0; i < entropies.size(); ++i) {
- RecordPacketReceipt(entropies[i].first, entropies[i].second);
- }
-
- std::sort(entropies.begin(), entropies.end());
-
- QuicPacketEntropyHash hash = 0;
- size_t index = 0;
- for (size_t i = 1; i <= (*entropies.rbegin()).first; ++i) {
- if (entropies[index].first == i) {
- hash ^= entropies[index].second;
- ++index;
- }
- if (i < 3)
- continue;
- EXPECT_EQ(hash, received_manager_.EntropyHash(i));
- }
- // Reorder by 5 when 2 is received after 7.
- EXPECT_EQ(5u, stats_.max_sequence_reordering);
- EXPECT_EQ(0, stats_.max_time_reordering_us);
- EXPECT_EQ(2u, stats_.packets_reordered);
-}
-
-TEST_P(QuicReceivedPacketManagerTest, EntropyHashBelowLeastObserved) {
- if (GetParam().version > QUIC_VERSION_33) {
- return;
- }
- EXPECT_EQ(0, received_manager_.EntropyHash(0));
- RecordPacketReceipt(4, 5);
- EXPECT_EQ(0, received_manager_.EntropyHash(3));
-}
-
-TEST_P(QuicReceivedPacketManagerTest, EntropyHashAboveLargestObserved) {
- if (GetParam().version > QUIC_VERSION_33) {
- return;
- }
- EXPECT_EQ(0, received_manager_.EntropyHash(0));
- RecordPacketReceipt(4, 5);
- EXPECT_EQ(0, received_manager_.EntropyHash(3));
-}
-
-TEST_P(QuicReceivedPacketManagerTest, SetCumulativeEntropyUpTo) {
- if (GetParam().version > QUIC_VERSION_33) {
- return;
- }
- vector<pair<QuicPacketNumber, QuicPacketEntropyHash>> entropies;
- entropies.push_back(std::make_pair(1, 12));
- entropies.push_back(std::make_pair(2, 1));
- entropies.push_back(std::make_pair(3, 33));
- entropies.push_back(std::make_pair(4, 3));
- entropies.push_back(std::make_pair(6, 34));
- entropies.push_back(std::make_pair(7, 29));
-
- QuicPacketEntropyHash entropy_hash = 0;
- for (size_t i = 0; i < entropies.size(); ++i) {
- RecordPacketReceipt(entropies[i].first, entropies[i].second);
- entropy_hash ^= entropies[i].second;
- }
- EXPECT_EQ(entropy_hash, received_manager_.EntropyHash(7));
-
- // Now set the entropy hash up to 5 to be 100.
- entropy_hash ^= 100;
- for (size_t i = 0; i < 4; ++i) {
- entropy_hash ^= entropies[i].second;
- }
- QuicReceivedPacketManagerPeer::SetCumulativeEntropyUpTo(&received_manager_, 5,
- 100);
- EXPECT_EQ(entropy_hash, received_manager_.EntropyHash(7));
-
- QuicReceivedPacketManagerPeer::SetCumulativeEntropyUpTo(&received_manager_, 1,
- 50);
- EXPECT_EQ(entropy_hash, received_manager_.EntropyHash(7));
-
- // No reordering.
- EXPECT_EQ(0u, stats_.max_sequence_reordering);
- EXPECT_EQ(0, stats_.max_time_reordering_us);
- EXPECT_EQ(0u, stats_.packets_reordered);
-}
-
-TEST_P(QuicReceivedPacketManagerTest, DontWaitForPacketsBefore) {
- QuicPacketHeader header;
- header.packet_number = 2u;
- received_manager_.RecordPacketReceived(0u, header, QuicTime::Zero());
- header.packet_number = 7u;
- received_manager_.RecordPacketReceived(0u, header, QuicTime::Zero());
- EXPECT_TRUE(received_manager_.IsAwaitingPacket(3u));
- EXPECT_TRUE(received_manager_.IsAwaitingPacket(6u));
- EXPECT_TRUE(QuicReceivedPacketManagerPeer::DontWaitForPacketsBefore(
- &received_manager_, 4));
- EXPECT_FALSE(received_manager_.IsAwaitingPacket(3u));
- EXPECT_TRUE(received_manager_.IsAwaitingPacket(6u));
-}
-
-TEST_P(QuicReceivedPacketManagerTest, GetUpdatedAckFrame) {
- QuicPacketHeader header;
- header.packet_number = 2u;
- QuicTime two_ms = QuicTime::Zero() + QuicTime::Delta::FromMilliseconds(2);
- EXPECT_FALSE(received_manager_.ack_frame_updated());
- received_manager_.RecordPacketReceived(0u, header, two_ms);
- EXPECT_TRUE(received_manager_.ack_frame_updated());
-
- QuicFrame ack = received_manager_.GetUpdatedAckFrame(QuicTime::Zero());
- EXPECT_FALSE(received_manager_.ack_frame_updated());
- // When UpdateReceivedPacketInfo with a time earlier than the time of the
- // largest observed packet, make sure that the delta is 0, not negative.
- EXPECT_EQ(QuicTime::Delta::Zero(), ack.ack_frame->ack_delay_time);
- EXPECT_EQ(1u, ack.ack_frame->received_packet_times.size());
-
- QuicTime four_ms = QuicTime::Zero() + QuicTime::Delta::FromMilliseconds(4);
- ack = received_manager_.GetUpdatedAckFrame(four_ms);
- EXPECT_FALSE(received_manager_.ack_frame_updated());
- // When UpdateReceivedPacketInfo after not having received a new packet,
- // the delta should still be accurate.
- EXPECT_EQ(QuicTime::Delta::FromMilliseconds(2),
- ack.ack_frame->ack_delay_time);
- // And received packet times won't have change.
- EXPECT_EQ(1u, ack.ack_frame->received_packet_times.size());
-
- header.packet_number = 999u;
- received_manager_.RecordPacketReceived(0u, header, two_ms);
- header.packet_number = 4u;
- received_manager_.RecordPacketReceived(0u, header, two_ms);
- header.packet_number = 1000u;
- received_manager_.RecordPacketReceived(0u, header, two_ms);
- EXPECT_TRUE(received_manager_.ack_frame_updated());
- ack = received_manager_.GetUpdatedAckFrame(two_ms);
- EXPECT_FALSE(received_manager_.ack_frame_updated());
- // UpdateReceivedPacketInfo should discard any times which can't be
- // expressed on the wire.
- EXPECT_EQ(2u, ack.ack_frame->received_packet_times.size());
-}
-
-TEST_P(QuicReceivedPacketManagerTest, UpdateReceivedConnectionStats) {
- EXPECT_FALSE(received_manager_.ack_frame_updated());
- RecordPacketReceipt(1, 0);
- EXPECT_TRUE(received_manager_.ack_frame_updated());
- RecordPacketReceipt(6, 0);
- RecordPacketReceipt(2, 0,
- QuicTime::Zero() + QuicTime::Delta::FromMilliseconds(1));
-
- EXPECT_EQ(4u, stats_.max_sequence_reordering);
- EXPECT_EQ(1000, stats_.max_time_reordering_us);
- EXPECT_EQ(1u, stats_.packets_reordered);
-}
-
-} // namespace
-} // namespace test
-} // namespace net
« no previous file with comments | « net/quic/quic_received_packet_manager.cc ('k') | net/quic/quic_sent_entropy_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698