Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Side by Side Diff: chrome/browser/resources/settings/site_settings/site_data.js

Issue 2193073002: Fix CrSettingsPrivacyPageTest.PrivacyPage test failure. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview 6 * @fileoverview
7 * 'site-data' handles showing the local storage summary list for all sites. 7 * 'site-data' handles showing the local storage summary list for all sites.
8 */ 8 */
9 9
10 Polymer({ 10 Polymer({
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
77 * @private 77 * @private
78 */ 78 */
79 onSiteTap_: function(event) { 79 onSiteTap_: function(event) {
80 var dialog = document.createElement('site-data-details-dialog'); 80 var dialog = document.createElement('site-data-details-dialog');
81 dialog.category = this.category; 81 dialog.category = this.category;
82 this.shadowRoot.appendChild(dialog); 82 this.shadowRoot.appendChild(dialog);
83 83
84 var node = this.treeNodes_.fetchNodeById(event.model.item.id, false); 84 var node = this.treeNodes_.fetchNodeById(event.model.item.id, false);
85 dialog.open(node); 85 dialog.open(node);
86 86
87 dialog.addEventListener('iron-overlay-closed', function(event) { 87 dialog.addEventListener('close', function(event) {
88 // The drop-down box in the dialog also generates iron-overlay-closed. 88 dialog.remove();
89 // Ignore anything but that event coming from a dialog object.
90 if (event.path[0].id == 'dialog')
91 dialog.remove();
92 }); 89 });
93 }, 90 },
94 }); 91 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698