[Android] [Reland] Sanitize APK signing file timestamps.

[Android] [Reland] Sanitize APK signing file timestamps.

This is a reland of http://crrev.com/2176023002#ps40001, with the added import of resource_sizes to patch python's zipfile. This allows older versions of python to process zip64 files.

BUG=630931, 632400
Committed: https://crrev.com/b2a0b3727c071668ad72461c9d77e10dc579e407
Cr-Commit-Position: refs/heads/master@{#409142}

[ghost stip (do not use), 2016-07-29 19:09:34]

Description was changed from

==========
[Android] [Reland] Sanitize APK signing file timestamps.

This is a reland of http://crrev.com/2176023002#ps40001, with the added import
of resource_sizes to patch python's zipfile. This allows older versions of
python to process zip64 files.

BUG=630931
==========

to

==========
[Android] [Reland] Sanitize APK signing file timestamps.

This is a reland of http://crrev.com/2176023002#ps40001, with the added import
of resource_sizes to patch python's zipfile. This allows older versions of
python to process zip64 files.

BUG=630931
==========

[ghost stip (do not use), 2016-07-29 19:09:34]

stip@chromium.org changed reviewers:
+ agrieve@chromium.org, jbudorick@chromium.org

[ghost stip (do not use), 2016-07-29 19:09:59]

ptal

seems to work, testing on internal now

[jbudorick, 2016-07-29 19:11:45]

https://codereview.chromium.org/2193063002/diff/20001/build/android/gyp/final...
File build/android/gyp/finalize_apk.py (right):

https://codereview.chromium.org/2193063002/diff/20001/build/android/gyp/final...
build/android/gyp/finalize_apk.py:16: import resource_sizes
Why are these out of order?

[ghost stip (do not use), 2016-07-29 20:12:09]

https://codereview.chromium.org/2193063002/diff/20001/build/android/gyp/final...
File build/android/gyp/finalize_apk.py (right):

https://codereview.chromium.org/2193063002/diff/20001/build/android/gyp/final...
build/android/gyp/finalize_apk.py:16: import resource_sizes
On 2016/07/29 19:11:45, jbudorick wrote:
> Why are these out of order?

need os and sys to do the PYTHONPATH adjustment

[jbudorick, 2016-07-29 20:18:08]

https://codereview.chromium.org/2193063002/diff/20001/build/android/gyp/final...
File build/android/gyp/finalize_apk.py (right):

https://codereview.chromium.org/2193063002/diff/20001/build/android/gyp/final...
build/android/gyp/finalize_apk.py:16: import resource_sizes
On 2016/07/29 20:12:09, stip wrote:
> On 2016/07/29 19:11:45, jbudorick wrote:
> > Why are these out of order?
> 
> need os and sys to do the PYTHONPATH adjustment

Right, but the standard python imports should precede resource_sizes and they
should be alphabetized.

[ghost stip (do not use), 2016-08-01 06:37:49]

ptal. seems to work on upstream and downstream. I'd like to do some more testing
before landing though

[ghost stip (do not use), 2016-08-02 00:44:14]

So far this is passing every upstream and downstream test I can throw at it. I
think it's ready for review.

[agrieve, 2016-08-02 01:02:02]

lgtm fun stuff :S

[ghost stip (do not use), 2016-08-02 03:52:28]

will wait for jbudorick's approval before landing

[ghost stip (do not use), 2016-08-02 03:53:29]

Description was changed from

==========
[Android] [Reland] Sanitize APK signing file timestamps.

This is a reland of http://crrev.com/2176023002#ps40001, with the added import
of resource_sizes to patch python's zipfile. This allows older versions of
python to process zip64 files.

BUG=630931
==========

to

==========
[Android] [Reland] Sanitize APK signing file timestamps.

This is a reland of http://crrev.com/2176023002#ps40001, with the added import
of resource_sizes to patch python's zipfile. This allows older versions of
python to process zip64 files.

BUG=630931, 632400
==========

[jbudorick, 2016-08-02 03:54:23]

On 2016/08/02 03:52:28, stip wrote:
> will wait for jbudorick's approval before landing

lgtm

[ghost stip (do not use), 2016-08-02 04:24:04]

The CQ bit was checked by stip@chromium.org

[commit-bot: I haz the power, 2016-08-02 04:24:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 05:34:59]

Description was changed from

==========
[Android] [Reland] Sanitize APK signing file timestamps.

This is a reland of http://crrev.com/2176023002#ps40001, with the added import
of resource_sizes to patch python's zipfile. This allows older versions of
python to process zip64 files.

BUG=630931, 632400
==========

to

==========
[Android] [Reland] Sanitize APK signing file timestamps.

This is a reland of http://crrev.com/2176023002#ps40001, with the added import
of resource_sizes to patch python's zipfile. This allows older versions of
python to process zip64 files.

BUG=630931, 632400
==========

[commit-bot: I haz the power, 2016-08-02 05:35:00]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-02 05:36:14]

Description was changed from

==========
[Android] [Reland] Sanitize APK signing file timestamps.

This is a reland of http://crrev.com/2176023002#ps40001, with the added import
of resource_sizes to patch python's zipfile. This allows older versions of
python to process zip64 files.

BUG=630931, 632400
==========

to

==========
[Android] [Reland] Sanitize APK signing file timestamps.

This is a reland of http://crrev.com/2176023002#ps40001, with the added import
of resource_sizes to patch python's zipfile. This allows older versions of
python to process zip64 files.

BUG=630931, 632400

Committed: https://crrev.com/b2a0b3727c071668ad72461c9d77e10dc579e407
Cr-Commit-Position: refs/heads/master@{#409142}
==========

[commit-bot: I haz the power, 2016-08-02 05:36:15]

Patchset 4 (id:??) landed as
https://crrev.com/b2a0b3727c071668ad72461c9d77e10dc579e407
Cr-Commit-Position: refs/heads/master@{#409142}