Restore the collapsed spaces of the text when we copy it

third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp

 /*
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2005 Alexey Proskuryakov.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 591 matching lines @@
                 if (str[runStart] == '\n') {
                     // We need to preserve new lines in case of PRE_LINE.
                     // See bug crbug.com/317365.
                     if (layoutObject->style()->whiteSpace() == PRE_LINE)
                         spliceBuffer('\n', m_node, 0, runStart, runStart);
                     else
                         spliceBuffer(spaceCharacter, m_node, 0, runStart, runStart + 1);
                     m_offset = runStart + 1;
                 } else {
                     size_t subrunEnd = str.find('\n', runStart);
-                    if (subrunEnd == kNotFound || subrunEnd > runEnd)
+                    if (subrunEnd == kNotFound || subrunEnd > runEnd) {
                         subrunEnd = runEnd;
+                        // Don't trim the space at the end of string because we need to
+                        // preserve it for copy & paste. See http://crbug.com/318925
+                        if (m_node->nextSibling() && isInline(m_node->nextSibling())) {

[joone, 2016/08/02 20:31:42]

This problem happens if the text node's next sibling is inline element like <a>,
<del>, <span> and etc

Here are examples:
<p>My favorite browser is <del>ABC</del> <ins>Chrome</ins>!</p>
<p>Counter: <span id="counter"></span></p>
<dfn>world <kbd>WebKit</kbd></dfn>
<div>Copy this area <a href="http://foo/">AVeryLongWordThatWillWrap</a></div>

So, if subrunEnd points the last character of the text node and the last
character is a plain space and there are not double spaces (it fixes some test
fails), we should include the last space by adding 1 to subrunEnd.

[yosin_UTC9, 2016/08/03 01:16:23]

How about this case?
<div><b><i>foo </i></b> bar</div>

Should we check following node of |m_node|, .e.g
isInline(Strategy::next(*m_node))?

[joone, 2016/08/03 21:50:59]

Works fine. I added this case to the test file.
Done

[joone, 2016/08/03 22:37:41]

When we reduce the width, the same problem happens:
expected <div style="width: 2em;"><b><i>foo </i></b> bar</div><div
contenteditable id="editor"><b><i>foo </i></b>bar|</div>,
but got  <div style="width: 2em;"><b><i>foo </i></b> bar</div><div
contenteditable id="editor"><b><i>foo</i></b>bar|</div>,

+                            if (str[str.length() - 1] == ' ' && subrunEnd == str.length() - 1 && str[subrunEnd-1] != ' ')

[yosin_UTC9, 2016/08/03 01:16:23]

nit: s/subrunEnd-1/subrunEnd - 1/

[joone, 2016/08/03 21:51:00]

Done.

+                                ++subrunEnd;
+                        }
+                    }
 
                     m_offset = subrunEnd;
                     emitText(m_node, layoutObject, runStart, subrunEnd);
                 }
 
                 // If we are doing a subrun that doesn't go to the end of the text box,
                 // come back again to finish handling this text box; don't advance to the next one.
                 if (static_cast<unsigned>(m_textState.positionEndOffset()) < textBoxEnd)
                     return;
 
@@ skipping 579 matching lines @@
 
 String plainText(const EphemeralRangeInFlatTree& range, TextIteratorBehaviorFlags behavior)
 {
     return createPlainText<EditingInFlatTreeStrategy>(range, behavior);
 }
 
 template class CORE_TEMPLATE_EXPORT TextIteratorAlgorithm<EditingStrategy>;
 template class CORE_TEMPLATE_EXPORT TextIteratorAlgorithm<EditingInFlatTreeStrategy>;
 
 } // namespace blink