Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2193033003:
Cancel browser process scroll bubbling when new gestures start (Closed)
|
Created:
4 years, 4 months ago by kenrb Modified:
4 years, 4 months ago CC:
chromium-reviews, darin-cc_chromium.org, jam, site-isolation-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionCancel browser process scroll bubbling when new gestures start
There are known issues with scroll bubbling causing a
RenderWidgetHostImpl to receive multiple GestureScrollBegin events
without seeing a GestureScrollEnd in between. This CL tightens up the
conditions during which inter-process scroll bubbling can occur to
prevent that situation.
BUG=631135, 627238
Committed: https://crrev.com/7b0c6f8719ccd5a23cf551b9413d7554673cb802
Cr-Commit-Position: refs/heads/master@{#409289}
Patch Set 1 #Patch Set 2 : Disable test on Android #
Total comments: 2
Patch Set 3 : Fixed indent #
Messages
Total messages: 23 (15 generated)
The CQ bit was checked by kenrb@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by kenrb@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
kenrb@chromium.org changed reviewers: + wjmaclean@chromium.org
James: PTAL?
Description was changed from ========== Cancel browser process scroll bubbling when new gestures start There are known issues with scroll bubbling causing a RenderWidgetHostImpl to receive multiple GestureScrollBegin events without seeing a GestureScrollEnd in between. This CL tightens up the conditions during which inter-process scroll bubbling can occur to prevent that situation. BUG=631135, 627238 ========== to ========== Cancel browser process scroll bubbling when new gestures start There are known issues with scroll bubbling causing a RenderWidgetHostImpl to receive multiple GestureScrollBegin events without seeing a GestureScrollEnd in between. This CL tightens up the conditions during which inter-process scroll bubbling can occur to prevent that situation. BUG=631135, 627238 ==========
On 2016/08/02 16:49:32, kenrb wrote: > James: PTAL? lgtm, thanks!
kenrb@chromium.org changed reviewers: + nasko@chromium.org
Nasko, can you review this as a content owner?
Rubberstamp LGTM with a nit. https://codereview.chromium.org/2193033003/diff/20001/content/browser/site_pe... File content/browser/site_per_process_browsertest.cc (right): https://codereview.chromium.org/2193033003/diff/20001/content/browser/site_pe... content/browser/site_per_process_browsertest.cc:967: // Navigate the nested frame to a page large enough to have scrollbars. nit: Since we are touching this test, can we fix the indent here?
Thanks for the reviews. https://codereview.chromium.org/2193033003/diff/20001/content/browser/site_pe... File content/browser/site_per_process_browsertest.cc (right): https://codereview.chromium.org/2193033003/diff/20001/content/browser/site_pe... content/browser/site_per_process_browsertest.cc:967: // Navigate the nested frame to a page large enough to have scrollbars. On 2016/08/02 18:25:11, nasko (slow) wrote: > nit: Since we are touching this test, can we fix the indent here? Done.
The CQ bit was checked by kenrb@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from wjmaclean@chromium.org, nasko@chromium.org Link to the patchset: https://codereview.chromium.org/2193033003/#ps40001 (title: "Fixed indent")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Cancel browser process scroll bubbling when new gestures start There are known issues with scroll bubbling causing a RenderWidgetHostImpl to receive multiple GestureScrollBegin events without seeing a GestureScrollEnd in between. This CL tightens up the conditions during which inter-process scroll bubbling can occur to prevent that situation. BUG=631135, 627238 ========== to ========== Cancel browser process scroll bubbling when new gestures start There are known issues with scroll bubbling causing a RenderWidgetHostImpl to receive multiple GestureScrollBegin events without seeing a GestureScrollEnd in between. This CL tightens up the conditions during which inter-process scroll bubbling can occur to prevent that situation. BUG=631135, 627238 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Cancel browser process scroll bubbling when new gestures start There are known issues with scroll bubbling causing a RenderWidgetHostImpl to receive multiple GestureScrollBegin events without seeing a GestureScrollEnd in between. This CL tightens up the conditions during which inter-process scroll bubbling can occur to prevent that situation. BUG=631135, 627238 ========== to ========== Cancel browser process scroll bubbling when new gestures start There are known issues with scroll bubbling causing a RenderWidgetHostImpl to receive multiple GestureScrollBegin events without seeing a GestureScrollEnd in between. This CL tightens up the conditions during which inter-process scroll bubbling can occur to prevent that situation. BUG=631135, 627238 Committed: https://crrev.com/7b0c6f8719ccd5a23cf551b9413d7554673cb802 Cr-Commit-Position: refs/heads/master@{#409289} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/7b0c6f8719ccd5a23cf551b9413d7554673cb802 Cr-Commit-Position: refs/heads/master@{#409289} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
