Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(631)

Issue 2193023003: Remove more unused landmines code (Closed)

Created:
4 years, 4 months ago by Nico
Modified:
4 years, 4 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove more unused landmines code Follow-up to https://codereview.chromium.org/2071463002/ BUG=none Committed: https://crrev.com/8205ee9cf8ad521a3c4efcbc505e53f4d53eadc6 Cr-Commit-Position: refs/heads/master@{#408871}

Patch Set 1 #

Total comments: 1

Patch Set 2 : derp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M build/get_landmines.py View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 25 (14 generated)
Nico
it says "msvc" somewhere in the diff
4 years, 4 months ago (2016-07-29 21:31:14 UTC) #4
scottmg
https://codereview.chromium.org/2193023003/diff/1/build/landmine_utils.py File build/landmine_utils.py (left): https://codereview.chromium.org/2193023003/diff/1/build/landmine_utils.py#oldcode52 build/landmine_utils.py:52: def gyp_generator_flags(): build/landmines.py? https://cs.chromium.org/search/?q=gyp_generator_flags&sq=package:chromium&type=cs
4 years, 4 months ago (2016-07-29 21:35:27 UTC) #7
Nico
Derp, I figured I removed that in https://codereview.chromium.org/2071463002/diff/20001/build/landmines.py and cs was just stale, but it's ...
4 years, 4 months ago (2016-07-29 21:37:05 UTC) #9
scottmg
lgtm
4 years, 4 months ago (2016-07-29 21:42:31 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2193023003/20001
4 years, 4 months ago (2016-07-29 21:45:25 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_gyp_rel on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_gyp_rel/builds/8001)
4 years, 4 months ago (2016-07-29 22:29:55 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2193023003/20001
4 years, 4 months ago (2016-07-29 22:32:58 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/228111)
4 years, 4 months ago (2016-07-29 22:39:19 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2193023003/20001
4 years, 4 months ago (2016-07-30 13:50:10 UTC) #22
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-30 14:08:52 UTC) #23
commit-bot: I haz the power
4 years, 4 months ago (2016-07-30 14:10:31 UTC) #25
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8205ee9cf8ad521a3c4efcbc505e53f4d53eadc6
Cr-Commit-Position: refs/heads/master@{#408871}

Powered by Google App Engine
This is Rietveld 408576698