|
|
DescriptionRemove more unused landmines code
Follow-up to https://codereview.chromium.org/2071463002/
BUG=none
Committed: https://crrev.com/8205ee9cf8ad521a3c4efcbc505e53f4d53eadc6
Cr-Commit-Position: refs/heads/master@{#408871}
Patch Set 1 #
Total comments: 1
Patch Set 2 : derp #
Messages
Total messages: 25 (14 generated)
The CQ bit was checked by thakis@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
thakis@chromium.org changed reviewers: + scottmg@chromium.org
it says "msvc" somewhere in the diff
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
https://codereview.chromium.org/2193023003/diff/1/build/landmine_utils.py File build/landmine_utils.py (left): https://codereview.chromium.org/2193023003/diff/1/build/landmine_utils.py#old... build/landmine_utils.py:52: def gyp_generator_flags(): build/landmines.py? https://cs.chromium.org/search/?q=gyp_generator_flags&sq=package:chromium&typ...
The CQ bit was checked by thakis@chromium.org to run a CQ dry run
Derp, I figured I removed that in https://codereview.chromium.org/2071463002/diff/20001/build/landmines.py and cs was just stale, but it's still there after my change. I reverted that change, thanks. On Fri, Jul 29, 2016 at 5:35 PM, <scottmg@chromium.org> wrote: > > https://codereview.chromium.org/2193023003/diff/1/build/landmine_utils.py > File build/landmine_utils.py (left): > > > https://codereview.chromium.org/2193023003/diff/1/build/landmine_utils.py#old... > build/landmine_utils.py:52: def gyp_generator_flags(): > build/landmines.py? > > https://cs.chromium.org/search/?q=gyp_generator_flags&sq=package:chromium&typ... > > https://codereview.chromium.org/2193023003/ > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by thakis@chromium.org
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win8_chromium_gyp_rel on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_gyp...)
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Remove more unused landmines code Follow-up to https://codereview.chromium.org/2071463002/ BUG=none ========== to ========== Remove more unused landmines code Follow-up to https://codereview.chromium.org/2071463002/ BUG=none Committed: https://crrev.com/8205ee9cf8ad521a3c4efcbc505e53f4d53eadc6 Cr-Commit-Position: refs/heads/master@{#408871} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/8205ee9cf8ad521a3c4efcbc505e53f4d53eadc6 Cr-Commit-Position: refs/heads/master@{#408871} |