Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2193003002: [Android] Remove host_info from chromium.perf.json testing config. (Closed)

Created:
4 years, 4 months ago by rnephew (Reviews Here)
Modified:
4 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Remove host_info from chromium.perf.json testing config. It is run via recipes now since it is suppose to run on every android bot similar to device_status and device_recovery. BUG=592140 Committed: https://crrev.com/e0dc697a670de04be1a15bd79bafef3aa0aad803 Cr-Commit-Position: refs/heads/master@{#408635}

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -84 lines) Patch
M testing/buildbot/chromium.perf.json View 6 chunks +0 lines, -84 lines 3 comments Download

Messages

Total messages: 16 (5 generated)
rnephew (Reviews Here)
Requires https://codereview.chromium.org/2192563004/ to land first.
4 years, 4 months ago (2016-07-28 21:26:38 UTC) #2
jbudorick
https://codereview.chromium.org/2193003002/diff/1/testing/buildbot/chromium.perf.json File testing/buildbot/chromium.perf.json (left): https://codereview.chromium.org/2193003002/diff/1/testing/buildbot/chromium.perf.json#oldcode153 testing/buildbot/chromium.perf.json:153: "Android One Perf (1)": { You may have to ...
4 years, 4 months ago (2016-07-28 21:29:45 UTC) #3
rnephew (Reviews Here)
https://codereview.chromium.org/2193003002/diff/1/testing/buildbot/chromium.perf.json File testing/buildbot/chromium.perf.json (left): https://codereview.chromium.org/2193003002/diff/1/testing/buildbot/chromium.perf.json#oldcode153 testing/buildbot/chromium.perf.json:153: "Android One Perf (1)": { On 2016/07/28 21:29:45, jbudorick ...
4 years, 4 months ago (2016-07-28 21:34:43 UTC) #4
ghost stip (do not use)
lgtm https://codereview.chromium.org/2193003002/diff/1/testing/buildbot/chromium.perf.json File testing/buildbot/chromium.perf.json (left): https://codereview.chromium.org/2193003002/diff/1/testing/buildbot/chromium.perf.json#oldcode153 testing/buildbot/chromium.perf.json:153: "Android One Perf (1)": { On 2016/07/28 21:29:45, ...
4 years, 4 months ago (2016-07-28 23:58:17 UTC) #5
jbudorick
lgtm
4 years, 4 months ago (2016-07-29 00:15:39 UTC) #6
sullivan
lgtm
4 years, 4 months ago (2016-07-29 00:55:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2193003002/1
4 years, 4 months ago (2016-07-29 01:06:52 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/271114)
4 years, 4 months ago (2016-07-29 01:33:54 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2193003002/1
4 years, 4 months ago (2016-07-29 13:36:51 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-29 14:25:10 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 14:28:05 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e0dc697a670de04be1a15bd79bafef3aa0aad803
Cr-Commit-Position: refs/heads/master@{#408635}

Powered by Google App Engine
This is Rietveld 408576698