chrome/browser/ui/bluetooth/bluetooth_chooser_controller.cc - Issue 2192953002: Chooser spinner should disappear as soon as one device shows up

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/bluetooth/bluetooth_chooser_controller.cc

Issue 2192953002: Chooser spinner should disappear as soon as one device shows up (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: chooser spinner should disappear as soon as one device shows up Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chooser_controller/chooser_controller.h ('K') | « chrome/browser/chooser_controller/mock_chooser_controller.cc ('k') | chrome/browser/ui/cocoa/chooser_content_view_cocoa.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/bluetooth/bluetooth_chooser_controller.cc

diff --git a/chrome/browser/ui/bluetooth/bluetooth_chooser_controller.cc b/chrome/browser/ui/bluetooth/bluetooth_chooser_controller.cc

index e212a7394fd190f34f144320030d8fb7cb5471b6..29513f928b3b5ae6908f43f06c2f4ea242047104 100644

--- a/chrome/browser/ui/bluetooth/bluetooth_chooser_controller.cc

+++ b/chrome/browser/ui/bluetooth/bluetooth_chooser_controller.cc

@@ -152,8 +152,11 @@ void BluetoothChooserController::AddDevice(const std::string& device_id,

const base::string16& device_name) {

device_names_and_ids_.push_back(std::make_pair(device_name, device_id));

++device_name_map_[device_name];

- if (view())

+ if (view()) {

view()->OnOptionAdded(device_names_and_ids_.size() - 1);

+ if (device_names_and_ids_.size() == 1)

+ view()->OnOptionAvailableDuringRefresh();

+ }

}

void BluetoothChooserController::RemoveDevice(const std::string& device_id) {