src/parsing/scanner.cc - Issue 2192883002: Make LiteralBuffer + LiteralScope private.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/parsing/scanner.cc

Issue 2192883002: Make LiteralBuffer + LiteralScope private. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Reorder declarations to avoid private forward decls. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/parsing/scanner.cc

diff --git a/src/parsing/scanner.cc b/src/parsing/scanner.cc

index 224aa401d061dbf3db70f3fa3692a9b1dae1e02a..0b1df2773883920fc4c75fc78b6666cfc25051d4 100644

--- a/src/parsing/scanner.cc

+++ b/src/parsing/scanner.cc

@@ -19,8 +19,7 @@

namespace v8 {

namespace internal {

-Handle<String> LiteralBuffer::Internalize(Isolate* isolate) const {

+Handle<String> Scanner::LiteralBuffer::Internalize(Isolate* isolate) const {

if (is_one_byte()) {

return isolate->factory()->InternalizeOneByteString(one_byte_literal());

}

« src/parsing/scanner.h ('K') | « src/parsing/scanner.h ('k') | no next file » | no next file with comments »