Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: src/parsing/parser.cc

Issue 2192883002: Make LiteralBuffer + LiteralScope private. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Reorder declarations to avoid private forward decls. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/parsing/scanner.h » ('j') | src/parsing/scanner.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/parsing/parser.cc
diff --git a/src/parsing/parser.cc b/src/parsing/parser.cc
index dcdc16b03823e170f8e0050d6c804a26dc1fa8ac..f18375f57f6158469796173158dbf95c3df5ba7e 100644
--- a/src/parsing/parser.cc
+++ b/src/parsing/parser.cc
@@ -5350,13 +5350,12 @@ IterationStatement* Parser::LookupContinueTarget(const AstRawString* label,
void Parser::HandleSourceURLComments(Isolate* isolate, Handle<Script> script) {
- if (scanner_.source_url()->length() > 0) {
- Handle<String> source_url = scanner_.source_url()->Internalize(isolate);
+ Handle<String> source_url = scanner_.SourceUrl(isolate);
+ if (!source_url.is_null()) {
script->set_source_url(*source_url);
}
- if (scanner_.source_mapping_url()->length() > 0) {
- Handle<String> source_mapping_url =
- scanner_.source_mapping_url()->Internalize(isolate);
+ Handle<String> source_mapping_url = scanner_.SourceMappingUrl(isolate);
+ if (!source_mapping_url.is_null()) {
script->set_source_mapping_url(*source_mapping_url);
}
}
« no previous file with comments | « no previous file | src/parsing/scanner.h » ('j') | src/parsing/scanner.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698