Make LiteralBuffer + LiteralScope private.

Make LiteralBuffer + LiteralScope private.

Reduce the Scanner API, in order to make subsequent rework easier.

R=marja@chromium.org
BUG=v8:4947
Committed: https://crrev.com/fab2efa84acc85e062781218192131e1106573d2
Cr-Commit-Position: refs/heads/master@{#38522}

[vogelheim, 2016-07-28 15:59:23]

ptal

[marja, 2016-08-05 07:05:46]

I noticed this in my review queue and I was wondering what was up with this
CL... did you want to try out something related to that part I commented on, or
what did we decide?

https://codereview.chromium.org/2192883002/diff/1/src/parsing/scanner.h
File src/parsing/scanner.h (right):

https://codereview.chromium.org/2192883002/diff/1/src/parsing/scanner.h#newco...
src/parsing/scanner.h:195: public:
We had some discussions about this part and... what did we conclude?

[vogelheim, 2016-08-09 11:47:28]

https://codereview.chromium.org/2192883002/diff/1/src/parsing/scanner.h
File src/parsing/scanner.h (right):

https://codereview.chromium.org/2192883002/diff/1/src/parsing/scanner.h#newco...
src/parsing/scanner.h:195: public:
On 2016/08/05 07:05:46, marja wrote:
> We had some discussions about this part and... what did we conclude?

We concluded that I shouldn't do this. Will update the CL.

[vogelheim, 2016-08-09 11:51:45]

The CQ bit was checked by vogelheim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-09 11:51:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vogelheim, 2016-08-09 11:57:24]

ptal

https://codereview.chromium.org/2192883002/diff/1/src/parsing/scanner.h
File src/parsing/scanner.h (right):

https://codereview.chromium.org/2192883002/diff/1/src/parsing/scanner.h#newco...
src/parsing/scanner.h:195: public:
On 2016/08/05 07:05:46, marja wrote:
> We had some discussions about this part and... what did we conclude?

Done. (As in: Removed this by reordering the declarations a bit.)

[commit-bot: I haz the power, 2016-08-09 12:21:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 12:21:42]

Dry run: This issue passed the CQ dry run.

[marja, 2016-08-10 08:15:08]

lgtm

https://codereview.chromium.org/2192883002/diff/20001/src/parsing/scanner.h
File src/parsing/scanner.h (right):

https://codereview.chromium.org/2192883002/diff/20001/src/parsing/scanner.h#n...
src/parsing/scanner.h:512: const int kMaxAscii = 127;
Not a problem of this CL, but I was wondering don't we have this constant
somewhere else too... maybe not.

[vogelheim, 2016-08-10 08:24:07]

https://codereview.chromium.org/2192883002/diff/20001/src/parsing/scanner.h
File src/parsing/scanner.h (right):

https://codereview.chromium.org/2192883002/diff/20001/src/parsing/scanner.h#n...
src/parsing/scanner.h:512: const int kMaxAscii = 127;
On 2016/08/10 08:15:08, marja wrote:
> Not a problem of this CL, but I was wondering don't we have this constant
> somewhere else too... maybe not.

https://cs.chromium.org/search/?q=127+file:src/v8/+file:%5C.h$&sq=package:chr...

:-|


Maybe unibrow::Utf8::kMaxOneByteChar? One could argue we're using it in a
different semantic context, though.

[vogelheim, 2016-08-10 08:38:40]

The CQ bit was checked by vogelheim@chromium.org

[commit-bot: I haz the power, 2016-08-10 08:38:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 08:40:32]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-10 08:40:49]

Description was changed from

==========
Make LiteralBuffer + LiteralScope private.

Reduce the Scanner API, in order to make subsequent rework easier.

R=marja@chromium.org
BUG=v8:4947
==========

to

==========
Make LiteralBuffer + LiteralScope private.

Reduce the Scanner API, in order to make subsequent rework easier.

R=marja@chromium.org
BUG=v8:4947

Committed: https://crrev.com/fab2efa84acc85e062781218192131e1106573d2
Cr-Commit-Position: refs/heads/master@{#38522}
==========

[commit-bot: I haz the power, 2016-08-10 08:40:50]

Patchset 2 (id:??) landed as
https://crrev.com/fab2efa84acc85e062781218192131e1106573d2
Cr-Commit-Position: refs/heads/master@{#38522}