Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2192883002: Make LiteralBuffer + LiteralScope private. (Closed)

Created:
4 years, 4 months ago by vogelheim
Modified:
4 years, 4 months ago
Reviewers:
marja
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make LiteralBuffer + LiteralScope private. Reduce the Scanner API, in order to make subsequent rework easier. R=marja@chromium.org BUG=v8:4947 Committed: https://crrev.com/fab2efa84acc85e062781218192131e1106573d2 Cr-Commit-Position: refs/heads/master@{#38522}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Reorder declarations to avoid private forward decls. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -185 lines) Patch
M src/parsing/parser.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M src/parsing/scanner.h View 1 4 chunks +178 lines, -178 lines 2 comments Download
M src/parsing/scanner.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
vogelheim
ptal
4 years, 4 months ago (2016-07-28 15:59:23 UTC) #1
marja
I noticed this in my review queue and I was wondering what was up with ...
4 years, 4 months ago (2016-08-05 07:05:46 UTC) #2
vogelheim
https://codereview.chromium.org/2192883002/diff/1/src/parsing/scanner.h File src/parsing/scanner.h (right): https://codereview.chromium.org/2192883002/diff/1/src/parsing/scanner.h#newcode195 src/parsing/scanner.h:195: public: On 2016/08/05 07:05:46, marja wrote: > We had ...
4 years, 4 months ago (2016-08-09 11:47:28 UTC) #3
vogelheim
ptal https://codereview.chromium.org/2192883002/diff/1/src/parsing/scanner.h File src/parsing/scanner.h (right): https://codereview.chromium.org/2192883002/diff/1/src/parsing/scanner.h#newcode195 src/parsing/scanner.h:195: public: On 2016/08/05 07:05:46, marja wrote: > We ...
4 years, 4 months ago (2016-08-09 11:57:24 UTC) #6
marja
lgtm https://codereview.chromium.org/2192883002/diff/20001/src/parsing/scanner.h File src/parsing/scanner.h (right): https://codereview.chromium.org/2192883002/diff/20001/src/parsing/scanner.h#newcode512 src/parsing/scanner.h:512: const int kMaxAscii = 127; Not a problem ...
4 years, 4 months ago (2016-08-10 08:15:08 UTC) #9
vogelheim
https://codereview.chromium.org/2192883002/diff/20001/src/parsing/scanner.h File src/parsing/scanner.h (right): https://codereview.chromium.org/2192883002/diff/20001/src/parsing/scanner.h#newcode512 src/parsing/scanner.h:512: const int kMaxAscii = 127; On 2016/08/10 08:15:08, marja ...
4 years, 4 months ago (2016-08-10 08:24:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2192883002/20001
4 years, 4 months ago (2016-08-10 08:38:50 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-10 08:40:32 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 08:40:50 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fab2efa84acc85e062781218192131e1106573d2
Cr-Commit-Position: refs/heads/master@{#38522}

Powered by Google App Engine
This is Rietveld 408576698