Fix GN generation for WinASAN build

build/config/sanitizers/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/chrome_build.gni")
 import("//build/config/chromecast_build.gni")
 import("//build/config/clang/clang.gni")
 import("//build/config/sanitizers/sanitizers.gni")
 import("//build/toolchain/toolchain.gni")
 
@@ skipping 62 matching lines @@
       ]
 
       public_deps = [
         ":asan_runtime_bundle_data",
       ]
     }
   }
 }
 
 if (is_mac && using_sanitizer) {
   copy("copy_asan_runtime") {

[Dirk Pranke, 2016/07/30 00:57:38]

I think you need to make this rule work as well on win, so that the right .dll
is copied into root_build_dir ; I had to manually copy them over before any of
the host targets would run as part of the build, and I assume I needed the
target dll as well for the targets binaries to run.

You'd need to fix the condition on line 70-73, above, as well.

     sources = [
       "$clang_base_path/lib/clang/$clang_version/lib/darwin/libclang_rt.asan_osx_dynamic.dylib",
     ]
     outputs = [
       "$root_out_dir/{{source_file_part}}",
     ]
   }
 
   bundle_data("asan_runtime_bundle_data") {
     sources = get_target_outputs(":copy_asan_runtime")
@@ skipping 140 matching lines @@
                   rebase_path("//tools/memory/asan/blacklist_win.txt",
                               root_build_dir) ]
     } else {
       # TODO(rnk): Remove this as discussed in http://crbug.com/427202.
       cflags +=
           [ "-fsanitize-blacklist=" +
             rebase_path("//tools/memory/asan/blacklist.txt", root_build_dir) ]
     }
 
     if (is_win) {
-      assert(current_cpu == "x86", "WinASan is 32-bit only currently")
-      if (is_component_build) {
-        libs = [
-          "clang_rt.asan_dynamic-i386.lib",
-          "clang_rt.asan_dynamic_runtime_thunk-i386.lib",
-        ]
+      if (target_cpu == "x64") {
+        # Windows 64-bit.
+        if (is_component_build) {
+          libs = [
+            "clang_rt.asan_dynamic-x86_64.lib",
+            "clang_rt.asan_dynamic_runtime_thunk-x86_64.lib",
+          ]
+        } else {
+          # TODO(etienneb): DLLs in the non-component build should link against
+          # clang_rt.asan_dll_thunk-x86_64.lib instead.
+          libs = [ "clang_rt.asan-x86_64.lib" ]
+        }
       } else {
-        # TODO(rnk): DLLs in the non-component build should link against
-        # clang_rt.asan_dll_thunk-i386.lib instead.
-        libs = [ "clang_rt.asan-i386.lib" ]
+        assert(target_cpu == "x86", "WinASan unsupported architecture")
+        if (is_component_build) {
+          libs = [
+            "clang_rt.asan_dynamic-i386.lib",
+            "clang_rt.asan_dynamic_runtime_thunk-i386.lib",
+          ]
+        } else {
+          # TODO(etienneb): DLLs in the non-component build should link against
+          # clang_rt.asan_dll_thunk-i386.lib instead.
+          libs = [ "clang_rt.asan-i386.lib" ]

[Dirk Pranke, 2016/07/30 00:57:38]

why not just change this to clang_rt.asan_dll_thunk-i386.lib, if this is true?

+        }
       }
     }
   }
 }
 
 config("cfi_flags") {
   cflags = []
   if (is_cfi && !is_nacl) {
     cfi_blacklist_path =
         rebase_path("//tools/cfi/blacklist.txt", root_build_dir)
@@ skipping 182 matching lines @@
 # This allows to selectively disable ubsan_vptr, when needed. In particular,
 # if some third_party code is required to be compiled without rtti, which
 # is a requirement for ubsan_vptr.
 config("default_sanitizer_flags_but_ubsan_vptr") {
   configs = all_sanitizer_configs - [ ":ubsan_vptr_flags" ]
 }
 
 config("default_sanitizer_flags_but_coverage") {
   configs = all_sanitizer_configs - [ ":coverage_flags" ]
 }