Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(188)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: LayoutTests/media/controls-timeline-with-controller-expected.txt
Issue
219283004
:
Remove what remains of MediaControllerInterface (Closed)
Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: earliest possible position FIXME
Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
LayoutTests/media/controls-timeline.html
LayoutTests/media/controls-timeline-expected.txt
LayoutTests/media/controls-timeline-with-controller.html
LayoutTests/media/controls-timeline-with-controller-expected.txt
Source/core/html/HTMLMediaElement.h
Source/core/html/MediaController.h
Source/core/html/MediaControllerInterface.h
Source/core/html/shadow/MediaControlElementTypes.h
Source/core/html/shadow/MediaControlElementTypes.cpp
Source/core/html/shadow/MediaControlElements.h
Source/core/html/shadow/MediaControlElements.cpp
Source/core/html/shadow/MediaControls.h
Source/core/html/shadow/MediaControls.cpp
View unified diff
|
Download patch
|
Annotate
|
Revision Log
« no previous file with comments
|
« LayoutTests/media/controls-timeline-with-controller.html
('k') |
Source/core/html/HTMLMediaElement.h »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
EVENT(loadedmetadata)
2
EXPECTED (video.controller.currentTime == '0') OK
3
EXPECTED (video.currentTime == '0') OK
4
EXPECTED (video.seeking == 'false') OK
5
EXPECTED (video.controller.currentTime / video.controller.duration > '0.4') OK
6
EXPECTED (video.controller.currentTime / video.controller.duration < '0.6') OK
7
EXPECTED (video.currentTime / video.duration > '0.4') OK
8
EXPECTED (video.currentTime / video.duration < '0.6') OK
9
EXPECTED (video.seeking == 'true') OK
10
END OF TEST
11
OLD
NEW
« no previous file with comments
|
« LayoutTests/media/controls-timeline-with-controller.html
('k') |
Source/core/html/HTMLMediaElement.h »
('j') |
no next file with comments »
Issue 219283004: Remove what remains of MediaControllerInterface (Closed)
Created 6 years, 8 months ago by philipj_slow
Modified 6 years, 8 months ago
Reviewers: acolwell GONE FROM CHROMIUM
Base URL: svn://svn.chromium.org/blink/trunk
Comments: 2
This is Rietveld
408576698
Chromium Code Reviews
Issue 219283004:
Remove what remains of MediaControllerInterface (Closed)
Base URL: svn://svn.chromium.org/blink/trunk