Remove what remains of MediaControllerInterface

Source/core/html/shadow/MediaControlElements.cpp

 /*
  * Copyright (C) 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 20 matching lines @@
 #include "core/html/shadow/MediaControlElements.h"
 
 #include "RuntimeEnabledFeatures.h"
 #include "bindings/v8/ExceptionStatePlaceholder.h"
 #include "core/dom/DOMTokenList.h"
 #include "core/dom/FullscreenElementStack.h"
 #include "core/dom/shadow/ShadowRoot.h"
 #include "core/events/MouseEvent.h"
 #include "core/frame/LocalFrame.h"
 #include "core/html/HTMLVideoElement.h"
+#include "core/html/MediaController.h"
 #include "core/html/shadow/MediaControls.h"
 #include "core/html/track/TextTrack.h"
 #include "core/html/track/vtt/VTTRegionList.h"
 #include "core/page/EventHandler.h"
 #include "core/rendering/RenderMediaControlElements.h"
 #include "core/rendering/RenderSlider.h"
 #include "core/rendering/RenderTheme.h"
 #include "core/rendering/RenderVideo.h"
 
 namespace WebCore {
@@ skipping 314 matching lines @@
 
     if (event->type() == EventTypeNames::mouseup)
         mediaControls().endScrubbing();
 
     MediaControlInputElement::defaultEventHandler(event);
 
     if (event->type() == EventTypeNames::mouseover || event->type() == EventTypeNames::mouseout || event->type() == EventTypeNames::mousemove)
         return;
 
     double time = value().toDouble();
-    if (event->type() == EventTypeNames::input && time != mediaControllerInterface().currentTime())
-        mediaControllerInterface().setCurrentTime(time, IGNORE_EXCEPTION);
+    if (event->type() == EventTypeNames::input) {
+        if (mediaElement().controller())
+            mediaElement().controller()->setCurrentTime(time, IGNORE_EXCEPTION);

[acolwell GONE FROM CHROMIUM, 2014/03/31 23:23:13]

nit: We should probably have a FIXME: here that indicates we'll need to properly
apply the media element's relative offset, once "timeline offset"(aka
getStartDate()) is implemented. A bug should probably be filed and associated
with http://crbug.com/312699

[philipj_slow, 2014/04/01 03:22:31]

getStartDate() returns the "timeline offset" which is "an explicit date and time
corresponding to the zero time in the media timeline" so I don't think that's
quite right.

The "earliest possible position" is however something that would affect the
media controls. https://code.google.com/p/chromium/issues/detail?id=137275 is
about that, so I've commented in that bug and will add a FIXME in the code
pointing to it.

+        else
+            mediaElement().setCurrentTime(time, IGNORE_EXCEPTION);
+    }
 
     RenderSlider* slider = toRenderSlider(renderer());
     if (slider && slider->inDragMode())
         mediaControls().updateCurrentTimeDisplay();
 }
 
 bool MediaControlTimelineElement::willRespondToMouseClickEvents()
 {
     return inDocument() && document().isActive();
 }
@@ skipping 282 matching lines @@
     float fontSize = smallestDimension * 0.05f;
     if (fontSize != m_fontSize) {
         m_fontSize = fontSize;
         setInlineStyleProperty(CSSPropertyFontSize, fontSize, CSSPrimitiveValue::CSS_PX);
     }
 }
 
 // ----------------------------
 
 } // namespace WebCore