Do not add -g0 with "clang=1 asan=1".

Do not add -g0 with "clang=1 asan=1".

clang=1 adds -g0 which overrides -gline-tables-only added by asan=1.
This change removes -g0 if asan=1 or msan=1 or tsan=1.

BUG=358126
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260536

[Alexander Potapenko, 2014-03-31 13:12:45]

LGTM

On Mon, Mar 31, 2014 at 3:53 PM,  <eugenis@chromium.org> wrote:
> Reviewers: Alexander Potapenko,
>
> Description:
> Do not add -g0 with "clang=1 asan=1".
>
> clang=1 adds -g0 which overrides -gline-tables-only added by asan=1.
> This change removes -g0 if asan=1 or msan=1 or tsan=1.
>
> BUG=358126
>
> Please review this at https://codereview.chromium.org/219283002/
>
> SVN Base: https://chromium.googlesource.com/chromium/src.git@master
>
> Affected files (+1, -1 lines):
>   M build/common.gypi
>
>
> Index: build/common.gypi
> diff --git a/build/common.gypi b/build/common.gypi
> index
>
8c94b1ff5069ff47e16151b375b130d1019b414b..1308a1d5a20e6efd81f13d27dd816df342fbff3b
> 100644
> --- a/build/common.gypi
> +++ b/build/common.gypi
> @@ -2364,7 +2364,7 @@
>            'GCC_GENERATE_DEBUGGING_SYMBOLS': 'NO',
>          },
>          'conditions': [
> -          ['clang==1', {
> +          ['clang==1 and asan==0 and msan==0 and tsan==0', {
>              # Clang creates chubby debug information, which makes linking
> very
>              # slow. For now, don't create debug information with clang.
> See
>              # http://crbug.com/70000
>
>



-- 
Alexander Potapenko
Software Engineer
Google Moscow

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[eugenis, 2014-03-31 13:30:23]

Committed patchset #2 manually as r260536.

[Alexander Potapenko, 2014-03-31 13:35:05]

lgtm