Add a FullWallet constructor for data obtained from SDK.

components/autofill/content/browser/wallet/full_wallet.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/content/browser/wallet/full_wallet.h"
 
 #include "base/logging.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/values.h"
@@ skipping 23 matching lines @@
       iin_(iin),
       encrypted_rest_(encrypted_rest),
       billing_address_(billing_address.Pass()),
       shipping_address_(shipping_address.Pass()),
       required_actions_(required_actions) {
   DCHECK(required_actions_.size() > 0 || billing_address_.get());
 }
 
 FullWallet::~FullWallet() {}
 
+// static
 scoped_ptr<FullWallet>
     FullWallet::CreateFullWallet(const DictionaryValue& dictionary) {
   const ListValue* required_actions_list;
   std::vector<RequiredAction> required_actions;
   if (dictionary.GetList("required_action", &required_actions_list)) {
     for (size_t i = 0; i < required_actions_list->GetSize(); ++i) {
       std::string action_string;
       if (required_actions_list->GetString(i, &action_string)) {
         RequiredAction action = ParseRequiredActionFromString(action_string);
         if (!ActionAppliesToFullWallet(action)) {
@@ skipping 65 matching lines @@
 
   return scoped_ptr<FullWallet>(new FullWallet(expiration_month,
                                                expiration_year,
                                                iin,
                                                encrypted_rest,
                                                billing_address.Pass(),
                                                shipping_address.Pass(),
                                                required_actions));
 }
 
+// static
+scoped_ptr<FullWallet>
+    FullWallet::CreateFullWalletFromClearText(
+        int expiration_month,
+        int expiration_year,
+        const std::string& pan,
+        const std::string& cvn,
+        scoped_ptr<Address> billing_address,
+        scoped_ptr<Address> shipping_address) {
+  DCHECK(billing_address);
+  DCHECK(!pan.empty());
+  DCHECK(!cvn.empty());
+
+  scoped_ptr<FullWallet> wallet(
+      new FullWallet(
+          expiration_month,
+          expiration_year,
+          std::string(),
+          std::string(),
+          billing_address.Pass(),
+          shipping_address.Pass(),
+          std::vector<RequiredAction>()));

[Dan Beam, 2013/08/06 03:38:17]

nit: this seems to fit in 80 cols like this:

  scoped_ptr<FullWallet> wallet(new FullWallet(
      expiration_month,
      expiration_year,
      std::string()
      std::string(),
      billing_address.Pass(),
      shipping_address.Pass(),
      std::vector<RequiredAction>()));

[Dan Beam, 2013/08/06 03:38:17]

are you sure this can never has required actions?

[aruslan, 2013/08/07 18:21:16]

Done.

[aruslan, 2013/08/07 18:21:16]

Yes -- this is a final (non-negotiable) response; all necessary actions should
have already taken place.

+  wallet->pan_ = pan;
+  wallet->cvn_ = cvn;

[Dan Beam, 2013/08/06 03:38:17]

this is kind of nasty...

[aruslan, 2013/08/07 18:21:16]

Another option was to add a new constructor, and it was even more confusing. 
This one at least makes it clear what exactly goes on.

+  return wallet.Pass();
+}
+
 base::string16 FullWallet::GetInfo(AutofillFieldType type) {
   switch (type) {
     case CREDIT_CARD_NUMBER:
       return UTF8ToUTF16(GetPan());
 
     case CREDIT_CARD_NAME:
       return billing_address()->recipient_name();
 
     case CREDIT_CARD_VERIFICATION_CODE:
       return UTF8ToUTF16(GetCvn());
@@ skipping 146 matching lines @@
 }
 
 const std::string& FullWallet::GetCvn() {
   if (cvn_.empty())
     DecryptCardInfo();
   return cvn_;
 }
 
 }  // namespace wallet
 }  // namespace autofill