Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 219273002: Use OwnPtr|PassOwnPtr to pass a pointer of SpeechInputClient (Closed)

Created:
6 years, 8 months ago by gyuyoung-inactive
Modified:
6 years, 8 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Use OwnPtr|PassOwnPtr to pass a pointer of SpeechInputClient As r170438, WebViewImpl has owned m_m_speechInputClient member variable. However, it is also only used for passing a pointer of SpeechInputClient. It is useless. To remove it, we need to change parameter type to OwnPtr|PassOwnPtr in SpeechInput class. Besides OwnPtr|PassOwnPtr help to manage the client pointer more safely. BUG=N/A Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170576

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -15 lines) Patch
M Source/core/speech/SpeechInput.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/speech/SpeechInput.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/speech/SpeechInputClient.h View 1 chunk +1 line, -2 lines 0 comments Download
M Source/web/WebViewImpl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
gyuyoung-inactive
6 years, 8 months ago (2014-03-31 15:38:14 UTC) #1
haraken
LGTM (but I'm not an OWNER of web/).
6 years, 8 months ago (2014-03-31 15:41:25 UTC) #2
gyuyoung-inactive
On 2014/03/31 15:41:25, haraken wrote: > LGTM (but I'm not an OWNER of web/). jochen, ...
6 years, 8 months ago (2014-04-01 08:48:14 UTC) #3
jochen (gone - plz use gerrit)
lgtm
6 years, 8 months ago (2014-04-01 11:24:01 UTC) #4
gyuyoung-inactive
The CQ bit was checked by gyuyoung.kim@samsung.com
6 years, 8 months ago (2014-04-01 14:27:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/219273002/1
6 years, 8 months ago (2014-04-01 14:27:39 UTC) #6
commit-bot: I haz the power
6 years, 8 months ago (2014-04-01 15:36:39 UTC) #7
Message was sent while issue was closed.
Change committed as 170576

Powered by Google App Engine
This is Rietveld 408576698