Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 2192713003: Convert mediasource http tests to testharness.js (Closed)

Created:
4 years, 4 months ago by Srirama
Modified:
4 years, 4 months ago
Reviewers:
fs, foolip
CC:
blink-reviews, chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert mediasource http tests to testharness.js Cleaning mediasource http tests to use testharness.js instead of video-test.js. This will enable to upstream these tests to web-platform-tests. BUG=588956 Committed: https://crrev.com/e823e5e60d848de11799d3741fade5a68ca8681e Cr-Commit-Position: refs/heads/master@{#408616}

Patch Set 1 #

Total comments: 2

Patch Set 2 : address comment #

Messages

Total messages: 14 (8 generated)
Srirama
PTAL
4 years, 4 months ago (2016-07-28 12:48:35 UTC) #5
fs
lgtm https://codereview.chromium.org/2192713003/diff/1/third_party/WebKit/LayoutTests/http/tests/media/media-source/mediasource-garbage-collection-before-sourceopen.html File third_party/WebKit/LayoutTests/http/tests/media/media-source/mediasource-garbage-collection-before-sourceopen.html (left): https://codereview.chromium.org/2192713003/diff/1/third_party/WebKit/LayoutTests/http/tests/media/media-source/mediasource-garbage-collection-before-sourceopen.html#oldcode14 third_party/WebKit/LayoutTests/http/tests/media/media-source/mediasource-garbage-collection-before-sourceopen.html:14: function createMediaSourceURL() It may be reasonable to keep ...
4 years, 4 months ago (2016-07-28 17:18:03 UTC) #6
Srirama
https://codereview.chromium.org/2192713003/diff/1/third_party/WebKit/LayoutTests/http/tests/media/media-source/mediasource-garbage-collection-before-sourceopen.html File third_party/WebKit/LayoutTests/http/tests/media/media-source/mediasource-garbage-collection-before-sourceopen.html (left): https://codereview.chromium.org/2192713003/diff/1/third_party/WebKit/LayoutTests/http/tests/media/media-source/mediasource-garbage-collection-before-sourceopen.html#oldcode14 third_party/WebKit/LayoutTests/http/tests/media/media-source/mediasource-garbage-collection-before-sourceopen.html:14: function createMediaSourceURL() On 2016/07/28 17:18:03, fs (OoO until Aug ...
4 years, 4 months ago (2016-07-29 10:21:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2192713003/20001
4 years, 4 months ago (2016-07-29 10:21:56 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-29 11:22:16 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 11:25:05 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e823e5e60d848de11799d3741fade5a68ca8681e
Cr-Commit-Position: refs/heads/master@{#408616}

Powered by Google App Engine
This is Rietveld 408576698