Switch to PacketNumberQueue interval iteration and avoid allocations in new ACK frame generation. G…

net/quic/quic_protocol.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/quic/quic_protocol.h"
 
 #include "base/stl_util.h"
 #include "base/strings/string_number_conversions.h"
 #include "net/quic/quic_flags.h"
 #include "net/quic/quic_utils.h"
@@ skipping 546 matching lines @@
   if (!packet_number_intervals_.Contains(packet_number)) {
     return end();
   }
   IntervalSet<QuicPacketNumber>::const_iterator it =
       packet_number_intervals_.Find(packet_number);
   first = packet_number;
   last = packet_number_intervals_.rbegin()->max();
   return const_iterator(it, first, last);
 }
 
+PacketNumberQueue::const_interval_iterator PacketNumberQueue::begin_intervals()
+    const {
+  return packet_number_intervals_.begin();
+}
+
+PacketNumberQueue::const_interval_iterator PacketNumberQueue::end_intervals()
+    const {
+  return packet_number_intervals_.end();
+}
+
+PacketNumberQueue::const_reverse_interval_iterator
+PacketNumberQueue::rbegin_intervals() const {
+  return packet_number_intervals_.rbegin();
+}
+
+PacketNumberQueue::const_reverse_interval_iterator
+PacketNumberQueue::rend_intervals() const {
+  return packet_number_intervals_.rend();
+}
+
 ostream& operator<<(ostream& os, const PacketNumberQueue& q) {
   for (QuicPacketNumber packet_number : q) {
     os << packet_number << " ";
   }
   return os;
 }
 
 ostream& operator<<(ostream& os, const QuicAckFrame& ack_frame) {
   os << "{ entropy_hash: " << static_cast<int>(ack_frame.entropy_hash)
      << ", largest_observed: " << ack_frame.largest_observed
@@ skipping 288 matching lines @@
       is_unackable(false),
       has_crypto_handshake(has_crypto_handshake),
       num_padding_bytes(num_padding_bytes),
       retransmission(0) {}
 
 TransmissionInfo::TransmissionInfo(const TransmissionInfo& other) = default;
 
 TransmissionInfo::~TransmissionInfo() {}
 
 }  // namespace net