Improve chances for inlining of ExceptionState::throwIfNeeded()

Source/bindings/v8/ExceptionState.h

Index: Source/bindings/v8/ExceptionState.h
diff --git a/Source/bindings/v8/ExceptionState.h b/Source/bindings/v8/ExceptionState.h
index fbe338f09251e4ff18d7327696a07aea27008daa..a344c3e970db4cb300d1501693616054e8334305 100644
--- a/Source/bindings/v8/ExceptionState.h
+++ b/Source/bindings/v8/ExceptionState.h
@@ -86,13 +86,9 @@ public:
 
     bool throwIfNeeded()
     {
-        if (m_exception.isEmpty()) {
-            if (!m_code)
-                return false;
-            throwDOMException(m_code, String()); // FIXME: Do we ever hit this? If so, where and why?
-        }
-
-        V8ThrowException::throwError(m_exception.newLocal(m_isolate), m_isolate);
+        if (LIKELY(!hadException()))

[haraken, 2014/03/31 12:49:16]

Does this LIKELY matter for performance? If you're not sure, you can remove it.
We don't want to add meaningless LIKELY/UNLIKELY :)

[fs, 2014/03/31 12:57:00]

TBH I haven't checked generated code without it - I suspect it won't matter much
though (I'll check though). I'll drop unless I find something out that suggest
otherwise.

[fs, 2014/03/31 13:20:30]

Dropped.

+            return false;
+        throwException();
         return true;
     }
 
@@ -114,6 +110,7 @@ protected:
 
 private:
     void setException(v8::Handle<v8::Value>);
+    void throwException();
 
     String addExceptionContext(const String&) const;