Improve chances for inlining of ExceptionState::throwIfNeeded()

Source/bindings/v8/ExceptionState.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 68 matching lines @@
     virtual void throwSecurityError(const String& sanitizedMessage, const String& unsanitizedMessage = String());
 
     bool hadException() const { return !m_exception.isEmpty() || m_code; }
     void clearException();
 
     ExceptionCode code() const { return m_code; }
     const String& message() const { return m_message; }
 
     bool throwIfNeeded()
     {
-        if (m_exception.isEmpty()) {
-            if (!m_code)
-                return false;
-            throwDOMException(m_code, String()); // FIXME: Do we ever hit this? If so, where and why?
-        }
-
-        V8ThrowException::throwError(m_exception.newLocal(m_isolate), m_isolate);
+        if (!hadException())
+            return false;
+        throwException();
         return true;
     }
 
     Context context() const { return m_context; }
     const char* propertyName() const { return m_propertyName; }
     const char* interfaceName() const { return m_interfaceName; }
 
     void rethrowV8Exception(v8::Handle<v8::Value> value)
     {
         setException(value);
     }
 
 protected:
     ExceptionCode m_code;
     Context m_context;
     String m_message;
     const char* m_propertyName;
     const char* m_interfaceName;
 
 private:
     void setException(v8::Handle<v8::Value>);
+    void throwException();
 
     String addExceptionContext(const String&) const;
 
     ScopedPersistent<v8::Value> m_exception;
     v8::Handle<v8::Object> m_creationContext;
     v8::Isolate* m_isolate;
 };
 
 // Used if exceptions can/should not be directly thrown.
 class NonThrowableExceptionState FINAL : public ExceptionState {
 public:
     NonThrowableExceptionState(): ExceptionState(ExceptionState::UnknownContext, 0, 0, v8::Handle<v8::Object>(), v8::Isolate::GetCurrent()) { }
     virtual void throwDOMException(const ExceptionCode&, const String& message) OVERRIDE;
     virtual void throwTypeError(const String& message = String()) OVERRIDE;
     virtual void throwSecurityError(const String& sanitizedMessage, const String& unsanitizedMessage = String()) OVERRIDE;
 };
 
 // Used if any exceptions thrown are ignorable.
 class TrackExceptionState FINAL : public ExceptionState {
 public:
     TrackExceptionState(): ExceptionState(ExceptionState::UnknownContext, 0, 0, v8::Handle<v8::Object>(), v8::Isolate::GetCurrent()) { }
     virtual void throwDOMException(const ExceptionCode&, const String& message) OVERRIDE;
     virtual void throwTypeError(const String& message = String()) OVERRIDE;
     virtual void throwSecurityError(const String& sanitizedMessage, const String& unsanitizedMessage = String()) OVERRIDE;
 };
 
 } // namespace WebCore
 
 #endif // ExceptionState_h