Improve chances for inlining of ExceptionState::throwIfNeeded()

Source/bindings/v8/ExceptionState.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 61 matching lines @@
 {
     // FIXME: Assert that exception is not empty?
     if (exception.IsEmpty()) {
         clearException();
         return;
     }
 
     m_exception.set(m_isolate, exception);
 }
 
+void ExceptionState::throwException()
+{
+    ASSERT(!m_exception.isEmpty() || m_code);

[haraken, 2014/03/31 12:49:16]

Can this simply be ASSERT(!m_exception.isEmpty()) ?

[fs, 2014/03/31 12:57:00]

AFAIU that would then miss the "m_exception.isEmpty() && m_code" case which
existed previously (and is indicated unlikely to ever occur by the FIXME just
below.)
I'd happily remove it but then I suppose the following two lines
(throwDOMException(...)) should also be removed?

[haraken, 2014/03/31 13:00:05]

I'd just add ASSERT(!m_exception.isEmpty()) and remove the below if branch, but
you can try that in a separate CL.

+    if (m_exception.isEmpty())
+        throwDOMException(m_code, String()); // FIXME: Do we ever hit this? If so, where and why?
+    ASSERT(!m_exception.isEmpty());

[haraken, 2014/03/31 12:49:16]

Then you can remove this.

+    V8ThrowException::throwError(m_exception.newLocal(m_isolate), m_isolate);
+}
+
 void ExceptionState::throwTypeError(const String& message)
 {
     ASSERT(m_isolate);
     m_code = TypeError;
     m_message = message;
     setException(V8ThrowException::createTypeError(addExceptionContext(message), m_isolate));
 }
 
 void NonThrowableExceptionState::throwDOMException(const ExceptionCode& ec, const String& message)
 {
@@ skipping 58 matching lines @@
             processedMessage = ExceptionMessages::failedToDeleteIndexed(interfaceName(), message);
         else if (m_context == IndexedGetterContext)
             processedMessage = ExceptionMessages::failedToGetIndexed(interfaceName(), message);
         else if (m_context == IndexedSetterContext)
             processedMessage = ExceptionMessages::failedToSetIndexed(interfaceName(), message);
     }
     return processedMessage;
 }
 
 } // namespace WebCore