Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Issue 2192623002: Change memmove's back into memcpy's. No functional change. Not flag protected. (Closed)

Created:
4 years, 4 months ago by Ryan Hamilton
Modified:
4 years, 4 months ago
Reviewers:
Zhongyi Shi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change memmove's back into memcpy's. No functional change. Not flag protected. memmove is presently ~2.5x faster than memcpy, however isn't inlined with -minline-all-stringops. It turns out that when these effects combine, the net result is a no-op for performance. So let's switch back to memcpy, because memcpy is likely to be improved in the future, and seeing memmove's where they aren't needed is somewhat surprising. Merge internal change: 128366346 BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M net/quic/quic_packet_creator.cc View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 3 (1 generated)
Ryan Hamilton
4 years, 4 months ago (2016-07-27 21:32:31 UTC) #2
Zhongyi Shi
4 years, 4 months ago (2016-07-27 21:37:00 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698