Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2192573002:
bluetooth: Remove Web Bluetooth from Bad Flags Prompt. (Closed)
Descriptionbluetooth: Remove Web Bluetooth from Bad Flags Prompt.
Initially the --enable-web-bluetooth flag was considered risky because
the chooser UI had not yet been implemented -- thus not giving users
an affordance to accept or deny the request. The first device found
was always returned, premission presumed.
Now the chooser UI is implemented on all platforms, and
--enable-web-bluetooth no longer needs to be considered a bad flag.
This partially reverts
"bluetooth: Add a WebBluetooth command line flag"
https://codereview.chromium.org/1134473003
BUG=632106
Committed: https://crrev.com/7c2ad05d80370b0054011b9bcf80e922aec02a81
Cr-Commit-Position: refs/heads/master@{#409702}
Patch Set 1 #
Messages
Total messages: 24 (13 generated)
The CQ bit was checked by scheib@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
scheib@chromium.org changed reviewers: + jyasskin@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
jyasskin@chromium.org changed reviewers: + felt@chromium.org
Could you mention in the change description that this partially reverts https://codereview.chromium.org/1134473003? We'll probably want Adrienne or another Enamel person to LGTM too, from the security side. LGTM.
Description was changed from ========== bluetooth: Remove Web Bluetooth from Bad Flags Prompt. Initially the --enable-web-bluetooth flag was considered risky because the chooser UI had not yet been implemented -- thus not giving users an affordance to accept or deny the request. The first device found was always returned, premission presumed. Now the chooser UI is implemented on all platforms, and --enable-web-bluetooth no longer needs to be considered a bad flag. BUG=632106 ========== to ========== bluetooth: Remove Web Bluetooth from Bad Flags Prompt. Initially the --enable-web-bluetooth flag was considered risky because the chooser UI had not yet been implemented -- thus not giving users an affordance to accept or deny the request. The first device found was always returned, premission presumed. Now the chooser UI is implemented on all platforms, and --enable-web-bluetooth no longer needs to be considered a bad flag. This partially reverts "bluetooth: Add a WebBluetooth command line flag" https://codereview.chromium.org/1134473003 BUG=632106 ==========
Description updated - will wait for felt.
lgtm
The CQ bit was checked by scheib@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
scheib@chromium.org changed reviewers: + msw@chromium.org
msw, PTAL as ui OWNER
lgtm
The CQ bit was checked by scheib@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== bluetooth: Remove Web Bluetooth from Bad Flags Prompt. Initially the --enable-web-bluetooth flag was considered risky because the chooser UI had not yet been implemented -- thus not giving users an affordance to accept or deny the request. The first device found was always returned, premission presumed. Now the chooser UI is implemented on all platforms, and --enable-web-bluetooth no longer needs to be considered a bad flag. This partially reverts "bluetooth: Add a WebBluetooth command line flag" https://codereview.chromium.org/1134473003 BUG=632106 ========== to ========== bluetooth: Remove Web Bluetooth from Bad Flags Prompt. Initially the --enable-web-bluetooth flag was considered risky because the chooser UI had not yet been implemented -- thus not giving users an affordance to accept or deny the request. The first device found was always returned, premission presumed. Now the chooser UI is implemented on all platforms, and --enable-web-bluetooth no longer needs to be considered a bad flag. This partially reverts "bluetooth: Add a WebBluetooth command line flag" https://codereview.chromium.org/1134473003 BUG=632106 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== bluetooth: Remove Web Bluetooth from Bad Flags Prompt. Initially the --enable-web-bluetooth flag was considered risky because the chooser UI had not yet been implemented -- thus not giving users an affordance to accept or deny the request. The first device found was always returned, premission presumed. Now the chooser UI is implemented on all platforms, and --enable-web-bluetooth no longer needs to be considered a bad flag. This partially reverts "bluetooth: Add a WebBluetooth command line flag" https://codereview.chromium.org/1134473003 BUG=632106 ========== to ========== bluetooth: Remove Web Bluetooth from Bad Flags Prompt. Initially the --enable-web-bluetooth flag was considered risky because the chooser UI had not yet been implemented -- thus not giving users an affordance to accept or deny the request. The first device found was always returned, premission presumed. Now the chooser UI is implemented on all platforms, and --enable-web-bluetooth no longer needs to be considered a bad flag. This partially reverts "bluetooth: Add a WebBluetooth command line flag" https://codereview.chromium.org/1134473003 BUG=632106 Committed: https://crrev.com/7c2ad05d80370b0054011b9bcf80e922aec02a81 Cr-Commit-Position: refs/heads/master@{#409702} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/7c2ad05d80370b0054011b9bcf80e922aec02a81 Cr-Commit-Position: refs/heads/master@{#409702} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
