scripts/slave/recipes/android/perf.py - Issue 2192563004: [Android] Move host_info from test config to recipe step for android perf bots.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/android/perf.py

Issue 2192563004: [Android] Move host_info from test config to recipe step for android perf bots. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: [Android] Move host_info from test config to recipe step for android perf bots. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipe_modules/chromium_android/api.py ('k') | scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__1_.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/android/perf.py

diff --git a/scripts/slave/recipes/android/perf.py b/scripts/slave/recipes/android/perf.py

index 068a07e53e027fa6428f28d7b022bf533ad80215..23f1fc52813e7aff5d8b60cbbd1a0100f7fb8508 100644

--- a/scripts/slave/recipes/android/perf.py

+++ b/scripts/slave/recipes/android/perf.py

@@ -166,6 +166,9 @@ def RunSteps(api):

for apk in required_apks:

api.chromium_android.adb_install_apk(apk)

+ api.chromium_android.host_info(

+ args=api.chromium_tests.get_common_args_for_scripts())

test_runner = api.chromium_tests.create_test_runner(

api, builder.get('tests', []))

@@ -299,3 +302,18 @@ def GenTests(api):

target='Release') +

api.override_step_data(

'perf_test.foo', retcode=87))

+ yield (api.test('host_info_failure') +

+ api.properties.generic(

+ path_config='kitchen',

+ repo_name='src',

+ repo_url=REPO_URL,

+ mastername='chromium.perf',

+ buildername='Android Nexus5 Perf (1)',

+ parent_buildername='parent_buildername',

+ parent_buildnumber='1729',

+ parent_revision='deadbeef',

+ revision='deadbeef',

+ slavename='slavename',

+ target='Release')

+ + api.step_data('Host_Info', retcode=87))