Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Unified Diff: scripts/slave/recipe_modules/chromium_android/api.py

Issue 2192563004: [Android] Move host_info from test config to recipe step for android perf bots. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: [Android] Move host_info from test config to recipe step for android perf bots. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipe_modules/chromium_android/api.py
diff --git a/scripts/slave/recipe_modules/chromium_android/api.py b/scripts/slave/recipe_modules/chromium_android/api.py
index fbfec8e17be6e2345d98e4734bab22c907cf8e2d..fba03ef6917618d4a304070db21e4e7426bd32b9 100644
--- a/scripts/slave/recipe_modules/chromium_android/api.py
+++ b/scripts/slave/recipe_modules/chromium_android/api.py
@@ -370,6 +370,20 @@ class AndroidApi(recipe_api.RecipeApi):
self.device_recovery()
return self.device_status()
+ def host_info(self, args=[], **kwargs):
+ try:
+ with self.handle_exit_codes():
+ args.extend(['run', '--output', self.m.json.output()])
+ self.m.step(
jbudorick 2016/07/28 20:23:11 Add some step test data here, please.
rnephew (Reviews Here) 2016/07/28 21:11:35 Done.
+ 'Host_Info',
+ [self.m.path['checkout'].join('testing', 'scripts',
+ 'host_info.py')] + args,
+ env=self.m.chromium.get_env(),
+ infra_step=True,
+ **kwargs)
+ except self.m.step.InfraFailure:
+ pass
rnephew (Reviews Here) 2016/07/28 19:24:16 We do not want it to fail hard when it experiences
jbudorick 2016/07/28 20:23:11 I think this is ok. I'm not sure it'll cause the b
+
def device_recovery(self, restart_usb=False, **kwargs):
args = [
'--blacklist-file', self.blacklist_file,

Powered by Google App Engine
This is Rietveld 408576698