[Android] Move host_info from test config to recipe step for android perf bots.

[Android] Move host_info from test config to recipe step for android perf bots.

BUG=592140
Committed: https://chromium.googlesource.com/chromium/tools/build/+/36cbc8822d8db7930985047241e90a2e6f96c17e

[rnephew (Reviews Here), 2016-07-28 19:24:15]

rnephew@chromium.org changed reviewers:
+ bpastene@chromium.org, dtu@chromium.org, jbudorick@chromium.org,
martiniss@chromium.org, stip@chromium.org

[rnephew (Reviews Here), 2016-07-28 19:24:16]

https://codereview.chromium.org/2192563004/diff/20001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/chromium_android/api.py (right):

https://codereview.chromium.org/2192563004/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_android/api.py:385: pass
We do not want it to fail hard when it experiences an issue, just turn purple.
I'm not sure if this is the correct way of doing this or not.

[rnephew (Reviews Here), 2016-07-28 19:24:40]

Patchset #1 (id:1) has been deleted

[dtu, 2016-07-28 20:17:03]

lgtm

[jbudorick, 2016-07-28 20:23:11]

https://codereview.chromium.org/2192563004/diff/20001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/chromium_android/api.py (right):

https://codereview.chromium.org/2192563004/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_android/api.py:377: self.m.step(
Add some step test data here, please.

https://codereview.chromium.org/2192563004/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_android/api.py:385: pass
On 2016/07/28 19:24:16, rnephew (Reviews Here) wrote:
> We do not want it to fail hard when it experiences an issue, just turn purple.
> I'm not sure if this is the correct way of doing this or not.

I think this is ok. I'm not sure it'll cause the build to fail on its own, but I
do think it'll cause the step to go purple, and I think the steps that would run
on this will still be red and consequently fail the build.

https://codereview.chromium.org/2192563004/diff/20001/scripts/slave/recipes/a...
File
scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__1_.json
(right):

https://codereview.chromium.org/2192563004/diff/20001/scripts/slave/recipes/a...
scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__1_.json:457:
"@@@STEP_LOG_LINE@json.output (invalid)@null@@@",
?

[rnephew (Reviews Here), 2016-07-28 21:11:36]

https://codereview.chromium.org/2192563004/diff/20001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/chromium_android/api.py (right):

https://codereview.chromium.org/2192563004/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_android/api.py:377: self.m.step(
On 2016/07/28 20:23:11, jbudorick wrote:
> Add some step test data here, please.

Done.

[jbudorick, 2016-07-28 21:11:59]

On 2016/07/28 21:11:36, rnephew (Reviews Here) wrote:
>
https://codereview.chromium.org/2192563004/diff/20001/scripts/slave/recipe_mo...
> File scripts/slave/recipe_modules/chromium_android/api.py (right):
> 
>
https://codereview.chromium.org/2192563004/diff/20001/scripts/slave/recipe_mo...
> scripts/slave/recipe_modules/chromium_android/api.py:377: self.m.step(
> On 2016/07/28 20:23:11, jbudorick wrote:
> > Add some step test data here, please.
> 
> Done.

.swp files :(

[rnephew (Reviews Here), 2016-07-28 21:16:11]

On 2016/07/28 21:11:59, jbudorick wrote:
> On 2016/07/28 21:11:36, rnephew (Reviews Here) wrote:
> >
>
https://codereview.chromium.org/2192563004/diff/20001/scripts/slave/recipe_mo...
> > File scripts/slave/recipe_modules/chromium_android/api.py (right):
> > 
> >
>
https://codereview.chromium.org/2192563004/diff/20001/scripts/slave/recipe_mo...
> > scripts/slave/recipe_modules/chromium_android/api.py:377: self.m.step(
> > On 2016/07/28 20:23:11, jbudorick wrote:
> > > Add some step test data here, please.
> > 
> > Done.
> 
> .swp files :(

Fixed. Those should really be ignored.

[jbudorick, 2016-07-28 21:18:56]

lgtm

[rnephew (Reviews Here), 2016-07-28 21:20:32]

The CQ bit was checked by rnephew@chromium.org

[rnephew (Reviews Here), 2016-07-28 21:20:33]

The patchset sent to the CQ was uploaded after l-g-t-m from dtu@chromium.org
Link to the patchset: https://codereview.chromium.org/2192563004/#ps60001
(title: "[Android] Move host_info from test config to recipe step for android
perf bots.")

[commit-bot: I haz the power, 2016-07-28 21:20:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 21:25:21]

Description was changed from

==========
[Android] Move host_info from test config to recipe step for android perf bots.

BUG=592140
==========

to

==========
[Android] Move host_info from test config to recipe step for android perf bots.

BUG=592140

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/36cbc8822d8db7930985...
==========

[commit-bot: I haz the power, 2016-07-28 21:25:22]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/tools/build/+/36cbc8822d8db7930985...