Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 2192563003: Fix gitignores after moving inspector_protocol (Closed)

Created:
4 years, 4 months ago by Michael Achenbach
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix gitignores after moving inspector_protocol BUG=chromium:580337 TBR=yangguo@chromium.org, jochen@chromium.org, pfeldman@chromium.org NOTRY=true Committed: https://crrev.com/f3eff9344cc8c1a5265a30b4c5fa06238242820b Cr-Commit-Position: refs/heads/master@{#38120}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M .gitignore View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
Michael Achenbach
TBR devs with local compilation errors might need to nuke the old directory if present.
4 years, 4 months ago (2016-07-28 09:01:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2192563003/1
4 years, 4 months ago (2016-07-28 09:02:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-28 09:03:37 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f3eff9344cc8c1a5265a30b4c5fa06238242820b Cr-Commit-Position: refs/heads/master@{#38120}
4 years, 4 months ago (2016-07-28 09:06:52 UTC) #9
Yang
4 years, 4 months ago (2016-07-28 09:16:26 UTC) #10
Message was sent while issue was closed.
On 2016/07/28 09:06:52, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/f3eff9344cc8c1a5265a30b4c5fa06238242820b
> Cr-Commit-Position: refs/heads/master@{#38120}

Thank you! LGTM.

Powered by Google App Engine
This is Rietveld 408576698