Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 2192483002: Move bounds and width function sanity checks to computation function (Closed)

Created:
4 years, 4 months ago by drott
Modified:
4 years, 4 months ago
Reviewers:
kojii, eae, behdad
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move bounds and width function sanity checks to computation function They don't need to be on the inlined hot code path. This is an amendment to https://codereview.chromium.org/1980913002 which moved them from the computation function to the cache lookup function. BUG=610313 R=kojii,eae,behdad Committed: https://crrev.com/0045a6a845ff4e21dcfe718dd26e2e29ce867622 Cr-Commit-Position: refs/heads/master@{#408167}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M third_party/WebKit/Source/platform/fonts/SimpleFontData.h View 2 chunks +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/SimpleFontData.cpp View 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
drott
4 years, 4 months ago (2016-07-27 15:24:46 UTC) #3
eae
OK, LGTM
4 years, 4 months ago (2016-07-27 17:21:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2192483002/1
4 years, 4 months ago (2016-07-27 17:21:36 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-27 17:25:14 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 17:28:37 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0045a6a845ff4e21dcfe718dd26e2e29ce867622
Cr-Commit-Position: refs/heads/master@{#408167}

Powered by Google App Engine
This is Rietveld 408576698