ui/views/controls/scrollbar/cocoa_scroll_bar.mm - Issue 2192443003: MacViews: Fix scrolling when clicking on the views::ScrollView scroll track

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/scrollbar/cocoa_scroll_bar.mm

Issue 2192443003: MacViews: Fix scrolling when clicking on the views::ScrollView scroll track (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix test on non-mac Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ui/views/controls/scroll_view_unittest.cc ('K') | « ui/views/controls/scrollbar/base_scroll_bar.h ('k') | ui/views/controls/scrollbar/native_scroll_bar.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/views/controls/scrollbar/cocoa_scroll_bar.mm

diff --git a/ui/views/controls/scrollbar/cocoa_scroll_bar.mm b/ui/views/controls/scrollbar/cocoa_scroll_bar.mm

index f11ea1a237d0e9ef9e32d8911abdf6911be15023..3c6bb9b607f7881827abd4f587ee52ed03ff39c3 100644

--- a/ui/views/controls/scrollbar/cocoa_scroll_bar.mm

+++ b/ui/views/controls/scrollbar/cocoa_scroll_bar.mm

@@ -290,6 +290,7 @@ bool CocoaScrollBar::OnMousePressed(const ui::MouseEvent& event) {

void CocoaScrollBar::OnMouseReleased(const ui::MouseEvent& event) {

ResetOverlayScrollbar();

+ BaseScrollBar::OnMouseReleased(event);

}

void CocoaScrollBar::OnMouseEntered(const ui::MouseEvent& event) {

« ui/views/controls/scroll_view_unittest.cc ('K') | « ui/views/controls/scrollbar/base_scroll_bar.h ('k') | ui/views/controls/scrollbar/native_scroll_bar.h » ('j') | no next file with comments »