Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3536)

Unified Diff: chrome/browser/ui/webui/options/edit_dictionary_browsertest.js

Issue 2192433002: Disable EditDictionaryWebUITest.testRemoveNotification on Win7 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/options/edit_dictionary_browsertest.js
diff --git a/chrome/browser/ui/webui/options/edit_dictionary_browsertest.js b/chrome/browser/ui/webui/options/edit_dictionary_browsertest.js
index e939266fb197f27b52ce0dbeb99f751ee52a5b84..5bcb0e0b18ab6615b77c92190359e4f49d89fb1e 100644
--- a/chrome/browser/ui/webui/options/edit_dictionary_browsertest.js
+++ b/chrome/browser/ui/webui/options/edit_dictionary_browsertest.js
@@ -137,7 +137,13 @@ TEST_F('EditDictionaryWebUITest', 'testAddNotification', function() {
// Verify that dictionary hides newly removed words that arrived in a
// notification, but ignores duplicate remove notifications.
-TEST_F('EditDictionaryWebUITest', 'testRemoveNotification', function() {
+// TODO(crbug.com/631940): Flaky on Win 7.
+GEN('#if defined(OS_WIN)');
+GEN('#define MAYBE_testRemoveNotification DISABLED_testRemoveNotification');
+GEN('#else');
+GEN('#define MAYBE_testRemoveNotification testRemoveNotification');
+GEN('#endif // defined(OS_WIN)');
+TEST_F('EditDictionaryWebUITest', 'MAYBE_testRemoveNotification', function() {
// Begin with a dictionary with words 'foo', 'bar', 'baz', and 'baz'. The
// second instance of 'baz' appears because the user added the word twice.
// The backend keeps only one copy of the word.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698