Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 219243011: Mojo: Move mojo/public/bindings/tests/*.mojom to mojo/public/interfaces/bindings/tests/. (Closed)

Created:
6 years, 8 months ago by viettrungluu
Modified:
6 years, 8 months ago
CC:
chromium-reviews, viettrungluu+watch_chromium.org, tfarina, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Mojo: Move mojo/public/bindings/tests/*.mojom to mojo/public/interfaces/bindings/tests/. R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260957

Patch Set 1 #

Total comments: 2

Patch Set 2 : oops #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -226 lines) Patch
M mojo/apps/js/bindings/connection_unittests.js View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/apps/js/bindings/sample_service_unittests.js View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/bindings/js/codec_unittests.js View 1 chunk +1 line, -1 line 0 comments Download
M mojo/mojo_apps_js_unittests.isolate View 1 chunk +1 line, -1 line 0 comments Download
M mojo/mojo_js_unittests.isolate View 1 chunk +1 line, -1 line 0 comments Download
M mojo/mojo_public.gypi View 1 3 chunks +7 lines, -7 lines 0 comments Download
D mojo/public/bindings/tests/math_calculator.mojom View 1 chunk +0 lines, -19 lines 0 comments Download
D mojo/public/bindings/tests/sample_factory.mojom View 1 chunk +0 lines, -32 lines 0 comments Download
D mojo/public/bindings/tests/sample_import.mojom View 1 chunk +0 lines, -21 lines 0 comments Download
D mojo/public/bindings/tests/sample_import2.mojom View 1 chunk +0 lines, -29 lines 0 comments Download
D mojo/public/bindings/tests/sample_interfaces.mojom View 1 chunk +0 lines, -18 lines 0 comments Download
D mojo/public/bindings/tests/sample_service.mojom View 1 chunk +0 lines, -72 lines 0 comments Download
D mojo/public/bindings/tests/test_structs.mojom View 1 chunk +0 lines, -19 lines 0 comments Download
M mojo/public/cpp/bindings/tests/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/tests/handle_passing_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/tests/remote_ptr_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/cpp/bindings/tests/request_response_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/cpp/bindings/tests/sample_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/tests/type_conversion_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/public/interfaces/bindings/tests/math_calculator.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/interfaces/bindings/tests/sample_factory.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/interfaces/bindings/tests/sample_import.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/interfaces/bindings/tests/sample_import2.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/interfaces/bindings/tests/sample_interfaces.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/interfaces/bindings/tests/sample_service.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/interfaces/bindings/tests/test_structs.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
viettrungluu
(Dependent on https://codereview.chromium.org/218883013/.)
6 years, 8 months ago (2014-04-01 18:25:53 UTC) #1
darin (slow to review)
LGTM https://codereview.chromium.org/219243011/diff/1/mojo/mojo_public.gypi File mojo/mojo_public.gypi (right): https://codereview.chromium.org/219243011/diff/1/mojo/mojo_public.gypi#newcode157 mojo/mojo_public.gypi:157: 'public/interfaces/interfaces/bindings/tests/sample_interfaces.mojom', nit: sort
6 years, 8 months ago (2014-04-01 19:05:09 UTC) #2
viettrungluu
Thanks. https://codereview.chromium.org/219243011/diff/1/mojo/mojo_public.gypi File mojo/mojo_public.gypi (right): https://codereview.chromium.org/219243011/diff/1/mojo/mojo_public.gypi#newcode157 mojo/mojo_public.gypi:157: 'public/interfaces/interfaces/bindings/tests/sample_interfaces.mojom', On 2014/04/01 19:05:09, darin wrote: > nit: ...
6 years, 8 months ago (2014-04-01 19:14:11 UTC) #3
viettrungluu
6 years, 8 months ago (2014-04-01 22:31:19 UTC) #4
Message was sent while issue was closed. 
Committed patchset #3 manually as r260957 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698